Repository navigation
Correct the Reader extension privacy policy for install-time site access - #91
Merged
Merged
Conversation
The shipped extension requests https://*/* at install, queries the user's collection to recognize saved pages, fetches PDFs in the page with the user's site login, offers an opt-in Wikimedia Citoid lookup, and talks to log.mdbase.dev for collection log and file transport. Describe those flows, drop the optional saved-page permission and the nonexistent Disconnect and clear local data and desktop direct-access controls, and align the extension guide's permission notes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings https://mdbase.dev/apps/reader/extension/privacy/ in line with the shipped extension, as listed in mdbase-dev/mdbase-reader
docs/extension-store-checklist.mdand checked against mdbase-readerorigin/main(bce5dc81).Privacy page
https://*/*is requested at install (apps/extension/scripts/extension-manifest.mjs). Removed the "optional saved-page recognition" wording and the "turn it off to remove the permission" controls. Users can limit site access in Chrome. Settings → Pages you visit (SiteAccessStatus.tsx) can ask Chrome to restore it.saved-url-index.ts), sends a visited address when it matches that index (background-page-status.ts), and sends the current tab's address while the side panel is open (use-extension-capture.ts).credentials: "include"(page-capture.ts), with a direct extension fetch as fallback. PDFs go only to the collection, and cookies are not exported.citoid-setting.ts). When it's on and no DOI citation is found, the page address goes to Citoid without credentials. PDFs, private or local hosts, IP addresses and token-like query parameters are excluded (web-capture/src/citoid-url.ts,provider-claims.ts). The existing DOI paragraph already covered doi.org.log.mdbase.dev: described as the SDK's first-party collection log and file transport, not analytics (production SDKpackaged-trust.js, manifest host permissions). The existing "no advertising or third-party analytics SDK" statement still holds: no such dependency exists in the extension or the SDK.chrome.storage.syncuse.browser-direct-accessreportsunsupported). Uninstalling the extension is now the documented way to clear its browser data.Extension guide (
/apps/reader/extension/): fixed the same "Mark pages I've saved is off by default / optional HTTPS permission" claims, and noted Citoid andlog.mdbase.dev.Checks: ran
pnpm testlocally against sources at the pinnedsite-sources.jsonrefs (check, build, import:spec, check:links). All passed.