Repository navigation
Scope the Bases adapter's opt-out to view discovery - #65
Merged
Merged
Conversation
The adapter's Purpose said implementations without obsidian_bases_views ignore .base files, while its next section, Chapter 03, and both implementations store them as records whenever a collection lists base in record_extensions. The optional feature now covers only view discovery, execution and the x-obsidian section.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Purpose section of
adapters/obsidian-bases.mdsays implementations that do not advertiseobsidian_bases_views"ignore.basefiles". That contradicts the next section of the same document, Chapter 03 (baseis a YAML document record extension), and both implementations:optional_features: [](conformance/v0.4.0-rc.6.yml) yet stores.basefiles as records once a collection listsbaseinrecord_extensions.base(mdbase-connect commit 806fc2e).This change limits the opt-out to what the feature actually covers: the
x-obsidiansection and discovering or executing Bases as views. Records stay records.The wording matches the replacement sentence in #63, so whichever lands second rebases trivially.
check_test_levels.py,check_v03_tests.pyandgit diff --checkpass.