Repository navigation
Move to SDK 0.1.0-beta.188 and its new API - #69
Merged
Merged
Conversation
- Loopback page: reads take one options object (`get(ref, { include })`,
`queryPages(query, { include, onReset })`), `watchChanges(onChanges,
{ cursor })`, `submit` resolves one Write, and the write ledger is
`snapshot.sync.writes`.
- The page now forwards `MdbaseSync` (`state`, `connection`, `health`, ...)
instead of the removed StatusSummary `kind`/`text`. The plugin keys its
offline wording and notice on `connection`, keeping a busy, rate-limited
or signed-out service out of "Offline" as before, and uses its own
`readyText` where it held the SDK's ready text.
- Desktop link: conflict values are plain JSON, so `toPlain` goes.
Offline is no network or an unreachable service, as before; a replica that is still connecting is not offline. A first download still reads "Downloading the collection.": the page passes the replica's installing flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves the plugin to
@mdbase-dev/sdk@0.1.0-beta.188, whose API changed (mdbase-connect #1486). The first commit is the automation's repin and version bump from #68, unchanged; the rest moves the code. #68 cannot pass by itself.Changes
submitresolves oneWrite; record values are plain JSON; status comes from the SDK's oneMdbaseSyncobject.client.status.installing.A user could notice
Some detail lines under the status can read differently when two conditions hold at once, because the SDK now orders the states.
Checks
npm run lint,npm test(148 and 117 pass),npm run test:release(14 pass),npm run check:mobile(mobile safe, 3.8 MB raw).Not checked
The live Obsidian UX suite was not run. Only the production SDK is pinned in this repository; LAB and staging builds are made by hand with
--native-sdk.