Add dirac distribution - #28
Merged
Merged
Conversation
added 3 commits
September 29, 2025 09:30
The DiracDistribution represents a point mass distribution, concentrating all probability at a single value. This is useful for modeling deterministic variables or as a degenerate case in probabilistic models.
Introduces `TensorDirac`, a tensor-aware implementation of the Dirac delta (point mass) distribution. This distribution assigns probability one to a single support element. Key features include: - `sample` and `rsample` always return the point `value`. - `log_prob` is 0 for the exact `value` and -inf otherwise. - Correct implementation of statistical properties like `mean`, `variance`, `entropy`, `cdf`, and `icdf`. - Comprehensive test suite covering API matching, core operations, and `torch.compile` compatibility.
Introduces `atol` (absolute tolerance) and `rtol` (relative tolerance) parameters to `DiracDistribution` and `TensorDirac`. These parameters enable approximate equality checks for `log_prob` and `cdf` computations, addressing limitations of exact floating-point comparisons. The `icdf` method was also updated to correctly broadcast the point mass value. Default `atol` and `rtol` values are 0, maintaining existing exact equality behavior unless specified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.