Repository navigation
0.26.0: a step program's glob excludes paths, and dist-apk empties its class directories - #60
Open
Sunrisepeak wants to merge 1 commit into
Open
Sunrisepeak wants to merge 1 commit into
Sunrisepeak wants to merge 1 commit into
Conversation
…s class directories glob_options::exclude drops a match whose whole path matches a pattern, where `*` crosses a `/`: a step that archives every object of a build except the ones below one directory (an application core without the platform shell's entry) has no other way to say so. The cmake backend renders each pattern as an anchored regular expression filtering the matches. dist-apk's javac and kotlinc steps empty their class directories before they compile. A compiler adds classes and never removes one, so a source that left the package -- a library dropped from the graph, a file deleted -- kept its class in the directory d8 lists, and in the next package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
tools-steps:glob_options::excludedrops a match whose whole path matches one of its patterns. Unlike the finding pattern,*crosses a/, so*/platform/ios/App/*drops everything below such a directory at any depth. Thecmakebackend renders each pattern as an anchored regular expression and filters the matches withlist(FILTER ... EXCLUDE REGEX ...).dist-apk: thejavacandkotlincsteps empty their class directories before they compile.Why
find ... ! -pathunder/bin/shfor it today.d8lists, and so in the next package. Examples are a library dropped from the graph and a deleted file. This was measured with HuxerUI: a library's inferred Java sources were replaced by an explicit[package.metadata.dist-apk]table without them, and the old class was still dexed until the directory was removed by hand.Checks
tests/all-rules-compileasserts the rendered exclusions:*crossing/, regular-expression characters taken literally, and[!x]as a negated set. Built and run locally on Linux:all-rules-compile ok.cmake -Pover a tree with anobj/app/platform/ios/App/main.mm.o: only the other objects remain.Version 0.26.0. The docs
tools-steps.mdanddist-apk.mdare updated, and the README and plugin-development examples now name 0.26.0.