Repository navigation
0.23.1: dist-apk takes a generated Java root as an action input - #57
Merged
Merged
Conversation
A Java or Kotlin root inside the build's output, which a build program generated, declared a re-run glob the engine's walk never enters, and every build warned that it could never re-run. Such a root is now an input of the javac action only. The level-1 fixture generates a third root and the feature check asserts its class and the absence of the warning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A build program that generates Java sources under its output directory (HuxerUI's build rules generate an Android application shell there) got a warning on every build:
rerun_if_changed_glob("target/.../java/**/*.java") can never re-run it.root_in_projectnow answers a root insidemcpp::out_dir(),target/,.mcpp/or.git/as outside the project, so it is an input of thejavacaction and declares no glob; the build program that writes it already runs on every build.dist/apk.cppm: the rule and its reason.tests/apk-consumer: level 1 generates a third Java root undermcpp::out_dir();check-apk-features.sh(e) assertsGeneratedHelperinclasses.dexand no "can never re-run it" in the build and pack output.mcpp.toml,src/plugins.cppm, README and plugin-development;docs/dist-apk.mdnames the change.Measured locally on Linux (x86_64-linux-android): level-1 build and pack succeed,
dexdumplistsMainActivity,ExternalHelperandGeneratedHelper, and neither log contains the warning.