Skip to content

CI: a build program that ran is known by its compiled file, not by its status line #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sunrisepeak merged 1 commit into from
Sep 29, 2026
Merged

CI: a build program that ran is known by its compiled file, not by its status line #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/scripts/check-deps-and-qt.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,11 @@ qt_import_only() {
rm -rf target
mkdir -p target/ci
"$MCPP" build 2>&1 | tee target/ci/build.log
! grep -q 'build.mcpp running' target/ci/build.log ||
# A build program that ran was compiled first, into the package's
# target/: the program file is the evidence. The line mcpp prints for it
# is not (mcpp 2026.9.29.5 replaced `build.mcpp running <package>` with one
# line per program, and a search for the old words would pass either way).
! find target -name 'build.mcpp.bin' -o -name 'build.mcpp.exe' | grep -q . ||
fail "mcpp synthesised a build program for a package with no Qt source (mcpp#715)"
! grep -q 'no Qt SDK' target/ci/build.log ||
fail "a package with no Qt source reported a missing SDK"
Expand Down
Loading