Skip to content

Fix mctest TypeError on re-runs: displaytime never restored from JSON #2624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
willend merged 1 commit into from
Sep 3, 2026
+4 −2
Merged

Fix mctest TypeError on re-runs: displaytime never restored from JSON #2624

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions tools/Python/mctest/mctest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ def load(self,testnb=0):
self.linted=obj['linted']
self.compiled=obj['compiled']
self.compiletime=obj['compiletime']
self.displaytime=obj.get('displaytime')
self.displayed=obj['displayed']
self.didrun=obj['didrun']
self.runtime=obj['runtime']
Expand Down Expand Up @@ -419,11 +420,12 @@ def mccode_test(branchdir, testdir, limitinstrs=None, instrfilter=None, compfilt
logging.info(formatstr % test.instrname)
continue
if test.testnb <= 1:
displaytime = test.displaytime if test.displaytime is not None else 0
if test.displayed:
formatstr = "%-" + "%ds: Display OK (%ds)" % (maxnamelen+1, test.displaytime)
formatstr = "%-" + "%ds: Display OK (%ds)" % (maxnamelen+1, displaytime)
logging.info(formatstr % test.instrname)
else:
formatstr = "%-" + "%ds: Display FAILED (%ds)" % (maxnamelen+1, test.displaytime)
formatstr = "%-" + "%ds: Display FAILED (%ds)" % (maxnamelen+1, displaytime)
logging.info(formatstr % test.instrname)

# runable tests have testnb > 0
Expand Down
Loading