Skip to content

Add nowritefile parameter to all Union loggers and abs_loggers #2607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mads-bertelsen-agentic wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Add nowritefile parameter to all Union loggers and abs_loggers #2607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
b5663ce
Add nowritefile parameter to all Union loggers and abs_loggers
mads-bertelsen-agentic Aug 26, 2026
2b989e1
Run mccode-clangformat on changed Union logger files
mads-bertelsen-agentic Aug 27, 2026
1128bfe
Merge branch 'main' into nowritefile_for_union
willend Aug 29, 2026
2de3d90
Correct typo in tar filename, remove double 'comp' entry in suffix
willend Aug 29, 2026
d8b2fab
Correct artefact label...
willend Aug 29, 2026
b0e402f
Different lables om COMP and INSTR changes
willend Aug 29, 2026
5dbb686
Add an 'index' in test label pr. changed comp
willend Aug 29, 2026
42a3240
Spare a few more chars...
willend Aug 29, 2026
dbe8134
Shorten path even further...
willend Aug 29, 2026
753cf02
Sync changes to mcxtrace-basictest
willend Aug 29, 2026
fec40a4
Shorter unique identifier in testsuite workflows
willend Aug 29, 2026
4269190
Add $CC in basictest label
willend Aug 29, 2026
45bb95f
Go for 12-char uid identifier created from RUNNER_TRACKING_ID
willend Aug 29, 2026
0c0c4d0
Update testsuite workflows
willend Aug 29, 2026
d2cc42d
Merge branch 'main' into nowritefile_for_union
willend Aug 29, 2026
236017e
Shorten Union logger test instrument names for Windows path limits
mads-bertelsen-agentic Sep 3, 2026
44cc6e8
Merge branch 'mccode-dev:main' into nowritefile_for_union
mads-bertelsen-agentic Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...n/Unit_test_abs_logger_1D_space/README.md → ..._union/Test_abs_logger_1D_space/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# The `Unit_test_abs_logger_1D_space` Instrument
# The `Test_abs_logger_1D_space` Instrument

*McStas: Test of the 1 dimensional spatial absorption logger*

Expand Down Expand Up @@ -29,6 +29,6 @@ Parameters in **boldface** are required; the others are optional.

## Links

- [Source code](Unit_test_abs_logger_1D_space.instr) for `Unit_test_abs_logger_1D_space.instr`.
- [Source code](Test_abs_logger_1D_space.instr) for `Test_abs_logger_1D_space.instr`.

---
4 changes: 2 additions & 2 deletions ...space/Unit_test_abs_logger_1D_space.instr → ...r_1D_space/Test_abs_logger_1D_space.instr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* Risoe National Laboratory, Roskilde, Denmark
* Institut Laue Langevin, Grenoble, France
*
* Instrument: Union_unit_test_abs_logger_1D_space
* Instrument: Test_abs_logger_1D_space
*
* %Identification
* Written by: Mads Bertelsen
Expand All @@ -29,7 +29,7 @@
* %End
*******************************************************************************/

DEFINE INSTRUMENT Unit_test_abs_logger_1D_space()
DEFINE INSTRUMENT Test_abs_logger_1D_space()

DECLARE
%{
Expand Down
4 changes: 2 additions & 2 deletions ..._test_abs_logger_1D_space_event/README.md → .../Test_abs_logger_1D_space_event/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# The `Unit_test_abs_logger_1D_space_event` Instrument
# The `Test_abs_logger_1D_space_event` Instrument

*McStas: Test of Union_abs_logger_1D_space_event*

Expand All @@ -24,6 +24,6 @@ Parameters in **boldface** are required; the others are optional.

## Links

- [Source code](Unit_test_abs_logger_1D_space_event.instr) for `Unit_test_abs_logger_1D_space_event.instr`.
- [Source code](Test_abs_logger_1D_space_event.instr) for `Test_abs_logger_1D_space_event.instr`.

---
4 changes: 2 additions & 2 deletions ...Unit_test_abs_logger_1D_space_event.instr → ...vent/Test_abs_logger_1D_space_event.instr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* Risoe National Laboratory, Roskilde, Denmark
* Institut Laue Langevin, Grenoble, France
*
* Instrument: Unit_test_abs_logger_1D_space_event
* Instrument: Test_abs_logger_1D_space_event
*
* %Identification
* Written by: Mads Bertelsen
Expand All @@ -24,7 +24,7 @@
* %End
*******************************************************************************/

DEFINE INSTRUMENT Unit_test_abs_logger_1D_space_event()
DEFINE INSTRUMENT Test_abs_logger_1D_space_event()

DECLARE
%{
Expand Down
4 changes: 2 additions & 2 deletions ...it_test_abs_logger_1D_space_tof/README.md → ...nion/Test_abs_logger_1D_space_t/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# The `Unit_test_abs_logger_1D_space_tof` Instrument
# The `Test_abs_logger_1D_space_t` Instrument

*McStas: Test of abs_logger_1D_space_tof*

Expand Down Expand Up @@ -28,6 +28,6 @@ Parameters in **boldface** are required; the others are optional.

## Links

- [Source code](Unit_test_abs_logger_1D_space_tof.instr) for `Unit_test_abs_logger_1D_space_tof.instr`.
- [Source code](Test_abs_logger_1D_space_t.instr) for `Test_abs_logger_1D_space_t.instr`.

---
4 changes: 2 additions & 2 deletions ...f/Unit_test_abs_logger_1D_space_tof.instr → ..._space_t/Test_abs_logger_1D_space_t.instr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* Risoe National Laboratory, Roskilde, Denmark
* Institut Laue Langevin, Grenoble, France
*
* Instrument: Unit_test_abs_logger_1D_space_tof
* Instrument: Test_abs_logger_1D_space_t
*
* %Identification
* Written by: Mads Bertelsen
Expand All @@ -28,7 +28,7 @@
* %End
*******************************************************************************/

DEFINE INSTRUMENT Unit_test_abs_logger_1D_space_tof()
DEFINE INSTRUMENT Test_abs_logger_1D_space_t()

DECLARE
%{
Expand Down
4 changes: 2 additions & 2 deletions ...s_logger_1D_space_tof_to_lambda/README.md → .../Test_abs_logger_1D_space_t_lam/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# The `Unit_test_abs_logger_1D_space_tof_to_lambda` Instrument
# The `Test_abs_logger_1D_space_t_lam` Instrument

*McStas: Test of abs_logger_1D_space_tof_to_lambda that calculates wavelength from tof*

Expand Down Expand Up @@ -35,6 +35,6 @@ Parameters in **boldface** are required; the others are optional.

## Links

- [Source code](Unit_test_abs_logger_1D_space_tof_to_lambda.instr) for `Unit_test_abs_logger_1D_space_tof_to_lambda.instr`.
- [Source code](Test_abs_logger_1D_space_t_lam.instr) for `Test_abs_logger_1D_space_t_lam.instr`.

---
4 changes: 2 additions & 2 deletions ...t_abs_logger_1D_space_tof_to_lambda.instr → ..._lam/Test_abs_logger_1D_space_t_lam.instr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* Risoe National Laboratory, Roskilde, Denmark
* Institut Laue Langevin, Grenoble, France
*
* Instrument: Unit_test_abs_logger_1D_space_tof_to_lambda
* Instrument: Test_abs_logger_1D_space_t_lam
*
* %Identification
* Written by: Mads Bertelsen
Expand Down Expand Up @@ -36,7 +36,7 @@
* %End
*******************************************************************************/

DEFINE INSTRUMENT Unit_test_abs_logger_1D_space_tof_to_lambda()
DEFINE INSTRUMENT Test_abs_logger_1D_space_t_lam()

DECLARE
%{
Expand Down
4 changes: 2 additions & 2 deletions ...on/Unit_test_abs_logger_1D_time/README.md → ...ests_union/Test_abs_logger_1D_t/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# The `Unit_test_abs_logger_1D_time` Instrument
# The `Test_abs_logger_1D_t` Instrument

*McStas: Test of Union 1D time absorption logger*

Expand Down Expand Up @@ -28,6 +28,6 @@ Parameters in **boldface** are required; the others are optional.

## Links

- [Source code](Unit_test_abs_logger_1D_time.instr) for `Unit_test_abs_logger_1D_time.instr`.
- [Source code](Test_abs_logger_1D_t.instr) for `Test_abs_logger_1D_t.instr`.

---
4 changes: 2 additions & 2 deletions ...D_time/Unit_test_abs_logger_1D_time.instr → ...bs_logger_1D_t/Test_abs_logger_1D_t.instr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* Risoe National Laboratory, Roskilde, Denmark
* Institut Laue Langevin, Grenoble, France
*
* Instrument: Unit_test_abs_logger_1D_time
* Instrument: Test_abs_logger_1D_t
*
* %Identification
* Written by: Mads Bertelsen
Expand All @@ -28,7 +28,7 @@
* %End
*******************************************************************************/

DEFINE INSTRUMENT Unit_test_abs_logger_1D_time()
DEFINE INSTRUMENT Test_abs_logger_1D_t()

DECLARE
%{
Expand Down
6 changes: 3 additions & 3 deletions ...n/Unit_test_abs_logger_2D_space/README.md → ..._union/Test_abs_logger_2D_space/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# The `Unit_test_abs_logger_2D_space` Instrument
# The `Test_abs_logger_2D_space` Instrument

*McStas: Test for Union_abs_logger_2D_space*

Expand All @@ -12,7 +12,7 @@
## Description

```text
Test of absorption logger with basic geometry from Unit_test_loggers_base.
Test of absorption logger with basic geometry from Test_loggers_base.

Includes conditional component to test record_to_temp functionality
of investigated abs_logger.
Expand All @@ -27,6 +27,6 @@ Parameters in **boldface** are required; the others are optional.

## Links

- [Source code](Unit_test_abs_logger_2D_space.instr) for `Unit_test_abs_logger_2D_space.instr`.
- [Source code](Test_abs_logger_2D_space.instr) for `Test_abs_logger_2D_space.instr`.

---
6 changes: 3 additions & 3 deletions ...space/Unit_test_abs_logger_2D_space.instr → ...r_2D_space/Test_abs_logger_2D_space.instr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* Risoe National Laboratory, Roskilde, Denmark
* Institut Laue Langevin, Grenoble, France
*
* Instrument: Unit_test_abs_logger_2D_space
* Instrument: Test_abs_logger_2D_space
*
* %Identification
* Written by: Mads Bertelsen
Expand All @@ -16,7 +16,7 @@
* Test for Union_abs_logger_2D_space
*
* %Description
* Test of absorption logger with basic geometry from Unit_test_loggers_base.
* Test of absorption logger with basic geometry from Test_loggers_base.
*
* Includes conditional component to test record_to_temp functionality
* of investigated abs_logger.
Expand All @@ -27,7 +27,7 @@
* %End
*******************************************************************************/

DEFINE INSTRUMENT Unit_test_abs_logger_2D_space()
DEFINE INSTRUMENT Test_abs_logger_2D_space()

DECLARE
%{
Expand Down
4 changes: 2 additions & 2 deletions ...nion/Unit_test_abs_logger_event/README.md → ...sts_union/Test_abs_logger_event/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# The `Unit_test_abs_logger_event` Instrument
# The `Test_abs_logger_event` Instrument

*McStas: Test of Union_abs_logger_event*

Expand All @@ -24,6 +24,6 @@ Parameters in **boldface** are required; the others are optional.

## Links

- [Source code](Unit_test_abs_logger_event.instr) for `Unit_test_abs_logger_event.instr`.
- [Source code](Test_abs_logger_event.instr) for `Test_abs_logger_event.instr`.

---
4 changes: 2 additions & 2 deletions ...er_event/Unit_test_abs_logger_event.instr → ..._logger_event/Test_abs_logger_event.instr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* Risoe National Laboratory, Roskilde, Denmark
* Institut Laue Langevin, Grenoble, France
*
* Instrument: Unit_test_abs_logger_event
* Instrument: Test_abs_logger_event
*
* %Identification
* Written by: Mads Bertelsen
Expand All @@ -25,7 +25,7 @@
* %End
*******************************************************************************/

DEFINE INSTRUMENT Unit_test_abs_logger_event()
DEFINE INSTRUMENT Test_abs_logger_event()

DECLARE
%{
Expand Down
4 changes: 2 additions & 2 deletions ...s_union/Unit_test_abs_logger_nD/README.md → .../Tests_union/Test_abs_logger_nD/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# The `Unit_test_abs_logger_1D_space` Instrument
# The `Test_abs_logger_nD` Instrument

*McStas: Test of the monitor_nD like absorption logger*

Expand Down Expand Up @@ -29,6 +29,6 @@ Parameters in **boldface** are required; the others are optional.

## Links

- [Source code](Unit_test_abs_logger_nD.instr) for `Unit_test_abs_logger_nD.instr`.
- [Source code](Test_abs_logger_nD.instr) for `Test_abs_logger_nD.instr`.

---
4 changes: 2 additions & 2 deletions ...s_logger_nD/Unit_test_abs_logger_nD.instr → ...st_abs_logger_nD/Test_abs_logger_nD.instr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* Risoe National Laboratory, Roskilde, Denmark
* Institut Laue Langevin, Grenoble, France
*
* Instrument: Union_unit_test_abs_logger_1D_space
* Instrument: Test_abs_logger_nD
*
* %Identification
* Written by: Mads Bertelsen
Expand All @@ -29,7 +29,7 @@
* %End
*******************************************************************************/

DEFINE INSTRUMENT Unit_test_abs_logger_1D_space()
DEFINE INSTRUMENT Test_abs_logger_nD()

DECLARE
%{
Expand Down
4 changes: 2 additions & 2 deletions ...union/Unit_test_conditional_PSD/README.md → ...ests_union/Test_conditional_PSD/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# The `Unit_test_conditional_PSD` Instrument
# The `Test_conditional_PSD` Instrument

*McStas: Test of conditional_PSD*

Expand Down Expand Up @@ -26,6 +26,6 @@ Parameters in **boldface** are required; the others are optional.

## Links

- [Source code](Unit_test_conditional_PSD.instr) for `Unit_test_conditional_PSD.instr`.
- [Source code](Test_conditional_PSD.instr) for `Test_conditional_PSD.instr`.

---
4 changes: 2 additions & 2 deletions ...ional_PSD/Unit_test_conditional_PSD.instr → ...onditional_PSD/Test_conditional_PSD.instr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* Risoe National Laboratory, Roskilde, Denmark
* Institut Laue Langevin, Grenoble, France
*
* Instrument: Unit_test_conditional_PSD
* Instrument: Test_conditional_PSD
*
* %Identification
* Written by: Mads Bertelsen
Expand All @@ -25,7 +25,7 @@
* %End
*******************************************************************************/

DEFINE INSTRUMENT Unit_test_conditional_PSD()
DEFINE INSTRUMENT Test_conditional_PSD()

DECLARE
%{
Expand Down
4 changes: 2 additions & 2 deletions .../Unit_test_conditional_standard/README.md → ...union/Test_conditional_standard/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# The `Unit_test_conditional_standard` Instrument
# The `Test_conditional_standard` Instrument

*McStas: Test of Union_conditional_standard*

Expand Down Expand Up @@ -26,6 +26,6 @@ Parameters in **boldface** are required; the others are optional.

## Links

- [Source code](Unit_test_conditional_standard.instr) for `Unit_test_conditional_standard.instr`.
- [Source code](Test_conditional_standard.instr) for `Test_conditional_standard.instr`.

---
4 changes: 2 additions & 2 deletions ...dard/Unit_test_conditional_standard.instr → ..._standard/Test_conditional_standard.instr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* Risoe National Laboratory, Roskilde, Denmark
* Institut Laue Langevin, Grenoble, France
*
* Instrument: Unit_test_conditional_standard
* Instrument: Test_conditional_standard
*
* %Identification
* Written by: Mads Bertelsen
Expand All @@ -25,7 +25,7 @@
* %End
*******************************************************************************/

DEFINE INSTRUMENT Unit_test_conditional_standard()
DEFINE INSTRUMENT Test_conditional_standard()

DECLARE
%{
Expand Down
4 changes: 2 additions & 2 deletions ...Tests_union/Unit_test_logger_1D/README.md → ...ples/Tests_union/Test_logger_1D/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# The `Unit_test_logger_1D` Instrument
# The `Test_logger_1D` Instrument

*McStas: Test of Union 1D logger*

Expand Down Expand Up @@ -28,6 +28,6 @@ Parameters in **boldface** are required; the others are optional.

## Links

- [Source code](Unit_test_logger_1D.instr) for `Unit_test_logger_1D.instr`.
- [Source code](Test_logger_1D.instr) for `Test_logger_1D.instr`.

---
4 changes: 2 additions & 2 deletions ..._test_logger_1D/Unit_test_logger_1D.instr → ...union/Test_logger_1D/Test_logger_1D.instr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* Risoe National Laboratory, Roskilde, Denmark
* Institut Laue Langevin, Grenoble, France
*
* Instrument: Unit_test_logger_1D
* Instrument: Test_logger_1D
*
* %Identification
* Written by: Mads Bertelsen
Expand All @@ -28,7 +28,7 @@
* %End
*******************************************************************************/

DEFINE INSTRUMENT Unit_test_logger_1D()
DEFINE INSTRUMENT Test_logger_1D()

DECLARE
%{
Expand Down
4 changes: 2 additions & 2 deletions ...ests_union/Unit_test_logger_2DQ/README.md → ...les/Tests_union/Test_logger_2DQ/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# The `Unit_test_logger_2DQ` Instrument
# The `Test_logger_2DQ` Instrument

*McStas: Test of the Union 2DQ logger that shows scattering vector projected onto 2D plane*

Expand Down Expand Up @@ -29,6 +29,6 @@ Parameters in **boldface** are required; the others are optional.

## Links

- [Source code](Unit_test_logger_2DQ.instr) for `Unit_test_logger_2DQ.instr`.
- [Source code](Test_logger_2DQ.instr) for `Test_logger_2DQ.instr`.

---
Loading
Loading