Conversation
jumpy-cat
marked this pull request as ready for review
August 14, 2026 16:06
jumpy-cat
marked this pull request as draft
August 14, 2026 16:09
jumpy-cat
marked this pull request as ready for review
August 14, 2026 16:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Was debugging a cryptic test failure higher up the stack when I noticed the vitest version being used is 3 years old. Bumped that to the most recent stable version, which resulted in an better msg and allowed me to find the root cause: a typo in a url. The test passed historically because parseInt would take only the prefix and ignore the rest but the process of migrating to
documentedresulted in something more strict.Type of Change
fix)Related Issues
none
Changes Made
path.test.tsTesting Done
Flutter: n/a
Screenshots / Demo (if UI or notification change)
n/a
Checklist
[type](scope): short descriptionmainand is our current working update branch (e.g.maizebus2.1)print()/debugPrint()/console.log()left in production codeStack created with GitHub Stacks CLI • Give Feedback 💬