[Line Diagram]: Set up new line page LiveView to use the same header & tabs layout as the existing one - #3473
Merged
Merged
Conversation
…lert badge logic since they relied on `conn` and we're already onto `socket` at this point. It works, but could be prettier (code-wise)
…rs and line seem to drop them, so I only applied the params to the timetable
…r content, so I put in a basic skeleton to hold the main and right rail content.
lvachon1
marked this pull request as ready for review
September 3, 2026 18:12
smartling-github-connector
Bot
added
the
Not Ready for Translation
joshlarson
approved these changes
Sep 4, 2026
joshlarson
left a comment
joshlarson
left a comment
Contributor
There was a problem hiding this comment.
Just in time for the Spring, 1997 rating! Great stuff!
lvachon1
removed
the
Not Ready for Translation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: 💈Set up new line page LiveView to use the same header & tabs layout as the existing one
Implementation
Copied over the header from the existing line diagram.
The tab code depended on
connwhen we're already on tosocketso I had to reimplement some parts of that.Added in a basic layout skeleton to separate main and right-rail content
TODO: Make the URL generating code smarter, we don't technically need it, but for general web usability it would be nice
Screenshots
We need some actual content soon, otherwise I'm might just add a view counter, web ring links, and
Best Viewed in:
How to test
http://localhost:4001/schedules/Red/line_new - Confirm the header and tabs look right and behave appropriately.