Release 1.31.1 - #232
Conversation
delete old deploy
Improvement/edge case addressing
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 66f08eda17
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| try { | ||
| // Confirm that the target is still readable immediately before the authorized overwrite. | ||
| readNamedDocumentBytes(); | ||
| writeAndComplete(request); |
There was a problem hiding this comment.
After a conflict for document A is canceled, pendingExternalConflict remains set; if the user chooses Open, discards their edits, and selects document B, the open path never clears that request and onResume() displays it again. Selecting Overwrite here passes A's captured bytes to writeAndComplete(), which writes through the current filename and therefore replaces B with A's content. Clear or revalidate the pending request whenever the active document changes.
Useful? React with 👍 / 👎.
| @@ -0,0 +1 @@ | |||
| TODO: RELEASE NOTES (1.31.1) | |||
There was a problem hiding this comment.
The new version-62 changelogs all contain the configured TODO placeholder, so the release cannot pass its mandatory validation: scripts/release_tool.py validate calls validate_changelogs() and rejects every note containing a placeholder marker, while create-release.yml runs that validation before creating the tag. Replace these four placeholders with localized notes so the 1.31.1 release workflow can proceed.
Useful? React with 👍 / 👎.
1 participant
Release checklist