Improvement/edge case addressing - #231
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f7f9558982
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| readNamedDocumentBytes(); | ||
| writeAndComplete(request); |
There was a problem hiding this comment.
If the user cancels the initial conflict dialog, continues editing, and later backgrounds and resumes the activity, pendingExternalConflict still contains the bytes captured before those later edits. The resumed dialog passes that stale request here, so Overwrite reports success but writes the older snapshot; if the save was initiated by Open/New/Exit, finishSuccessfulSave also performs that queued action and removes the newer text from view. Rebuild the request from the current editor generation before overwriting, or refuse stale requests.
Useful? React with 👍 / 👎.
1 participant
No description provided.