Repository navigation
feat(gemini-review): review fork PRs, review only; v0.5.0 - #24
Merged
Merged
Conversation
A fork PR (marola-site#54) never got a review: the job skipped forks because pull_request gives them no secrets, though marola#641 asked for "a review but no push". Callers now trigger on pull_request_target; on a fork the workspace is the base branch, the fork's head is read as text from .pr-head (review --root) and the fix step is skipped. Same-repo PRs are unchanged. Closes #23 Tested: gemini_review.py --self-test ok (--root case red first); tests/self-tests.sh all ok; actionlint ok; docs-lint clean; ruff ok Cost: ~$0.6 est. Co-Authored-By: Claude <noreply@anthropic.com>
h0ffmann
marked this pull request as ready for review
October 4, 2026 22:03
Its post step spent 2m40s of a 6m23s devkit CI run (main, 2026-10-04) uploading store paths cache.nixos.org already serves; marola dropped it for the same reason in marola-dev/marola#658. Refs marola-dev/marola#657 Tested: actionlint ok; docs-lint clean; step timings from devkit CI on main Cost: ~$0.2 est. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Hoffmann · project thread
Summary: Before: requesting
geminion a fork PR (marola-dev/marola-site#54) did nothing, because the job skipped forks. After: a fork PR gets the Gemini review, with suggestion blocks, but no fix commit. Same-repo PRs work as before.gemini_review.py --self-test(the--rootcase failed first),tests/self-tests.sh, actionlint, ruff and docs-lint all pass. Live check: re-requestgeminion marola-site#54 once its caller is on v0.5.0What changed
gemini-review.ymlno longer skips forks. On a fork PR, the workspace is the base commit, so the guide is the repo's own. The fork's head is checked out into.pr-headas text only, nothing from it runs, and the fix step is skipped.gemini_review.py review --root DIRis the tree used to anchor suggestions (default.).pull_request_targetso a fork run gets the secrets. This is safe because only someone with triage access can request the team. This repo's owngemini.ymlmoves too.devkit-ciandapi-docsdropmagic-nix-cache-action, as ci: drop magic-nix-cache from quality-other and repo-stats marola#658 did. Its post step spent 2m40s of a 6m23s devkit CI run uploading paths cache.nixos.org already serves.docs/4-reference_workflows.md, the CHANGELOG and every pin move to v0.5.0.How: After merging, tag
v0.5.0. The six caller PRs then switch topull_request_targetand@v0.5.0.Closes #23
https://claude.ai/code/session_01NYzPmf2qCK2s2RYccvBVBY
Generated by Claude Code
Generated by Claude Code