MLE-31642 Update noSslContext Test - #1963
Merged
Merged
Conversation
MarkLogic 12.1 is now returning a 403 error code, like we expect, instead of closing the connection and throwing a MarkLogicIOException. - Removed @ExtendsWith(RequiresMLS11OrLower.class) annotation to run against ML12.1 - Updated comments to explain failure history if run against a MLS 12.0.x build - Removed noSslContextWithMarkLogic12()
jonmille
requested review from
RitaChen609,
ngodugu-marklogic,
rjdew-progress and
rjrudin
as code owners
August 3, 2026 14:25
There was a problem hiding this comment.
Pull request overview
Updates the one-way SSL JUnit test suite in marklogic-client-api to reflect MarkLogic 12.1’s restored behavior when an HTTP client connects to an HTTPS-required app server.
Changes:
- Removes the ML11-or-lower gating so
noSslContextruns against ML12.1+. - Replaces/expands in-test commentary to document the ML12.0.x “unexpected end of stream” behavior (MLE-17505) and its reversal in 12.1.
- Removes the dedicated MarkLogic 12-only variant test that expected an IO exception.
Comment on lines
+136
to
+140
| DatabaseClient.ConnectionResult result = client.checkConnection(); | ||
| assertEquals("Forbidden", result.getErrorMessage(), "MarkLogic is expected to return a 403 Forbidden when the " + | ||
| "user tries to access an HTTPS app server using HTTP. This behavior changes in MarkLogic 12, and it may " + | ||
| "be considered a bit surprising with MarkLogic 11 and earlier - that is, the user probably shouldn't get " + | ||
| "any response back since a connection cannot be made without using SSL."); | ||
| "user tries to access an HTTPS app server using HTTP. If this assertion fails with a MarkLogicIOException " + | ||
| "containing 'unexpected end of stream', the test is likely running against a pre-12.1 MarkLogic 12 build " + | ||
| "that exhibited the now-reverted MLE-17505 behaviour."); |
rjrudin
requested changes
Aug 3, 2026
rjrudin
left a comment
rjrudin
left a comment
Contributor
There was a problem hiding this comment.
This is definitely a good change by the server, but I think we need to keep a "RequiresML11OrLower" test that verifies that an IO exception is expected instead. While that's not desirable behavior, it's important to document that in one of our tests.
This reverts commit cf8d656.
- Updated noSslContext() to noSslContextWithMarkLogic11OrLower() - Added RequiresML12Dot0 to test ML 12.0.x versions - Updated noSslContextWithMarkLogic12() to extend with RequiresML12Dot0.class for only ML versions 12.0.x - Added noSslContextWithMarkLogic12Dot1OrHigher() for ML 12.1 and up behavior.
noSslContextWithMarkLogic11OrLower() -> noSslContext() and updated the ExtendsWith annotation to @ExtendWith({RequiresML11OrLower.class, RequiresML12Dot1.class})
This reverts commit f070abe.
Author
It IO exception was occurring for ML 12.0.x versions. The tests now cover the behaviors for 11 and lower, 12.0.x, and 12.1 and greater |
rjrudin
approved these changes
Aug 3, 2026
rjdew-progress
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MarkLogic 12.1 is now returning a 403 error code, like we expect, instead of closing the connection and throwing a MarkLogicIOException for ML 12.1.
Jira Ticket: https://progresssoftware.atlassian.net/browse/MLE-31642