Repository navigation
Conversation
Stored coordinates are Int32 truncations of encode(). The query used the untruncated value, so a point on the box edge fell just outside.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getClustersstores coordinates as Int32 truncations ofencode(), then queried with the untruncated value. The southwest and northeast corners of the box were left out.Test plan
-123.245515, 43.9150233333333and northeast-123.192528333333, 44.0307166666667are returned, and-124, 43is notnpm test19 passedMade with Cursor