fix(iam): authorize channel-project ACM certificate lifecycle - #48
Merged
Conversation
Contributor
OpenTofu TestOpenTofu test passed. View run output |
Contributor
OpenTofu PlanOpenTofu plan passed. View run outputOpenTofu will perform the following actions:
# aws_iam_role_policy.github_actions_channel_project_site_acm will be created
+ resource "aws_iam_role_policy" "github_actions_channel_project_site_acm" {
+ id = (known after apply)
+ name = "channel-project-site-acm"
+ name_prefix = (known after apply)
+ policy = jsonencode(
{
+ Statement = [
+ {
+ Action = [
+ "acm:RequestCertificate",
]
+ Effect = "Allow"
+ Resource = "*"
+ Sid = "RequestSiteViewerCertificate"
},
+ {
+ Action = [
+ "acm:AddTagsToCertificate",
+ "acm:DeleteCertificate",
+ "acm:DescribeCertificate",
+ "acm:ListTagsForCertificate",
+ "acm:RemoveTagsFromCertificate",
]
+ Effect = "Allow"
+ Resource = "arn:aws:acm:us-east-1:332355796717:certificate/*"
+ Sid = "ManageSiteViewerCertificate"
},
]
+ Version = "2012-10-17"
}
)
+ role = "github-actions-channel-project-site-infrastructure"
}
Plan: 1 to add, 0 to change, 0 to destroy.
OpenTofu will perform the following actions:
# aws_iam_role_policy.github_actions_channel_project_site_acm will be created
+ resource "aws_iam_role_policy" "github_actions_channel_project_site_acm" {
+ id = (known after apply)
+ name = "channel-project-site-acm"
+ name_prefix = (known after apply)
+ policy = jsonencode(
{
+ Statement = [
+ {
+ Action = [
+ "acm:RequestCertificate",
]
+ Effect = "Allow"
+ Resource = "*"
+ Sid = "RequestSiteViewerCertificate"
},
+ {
+ Action = [
+ "acm:AddTagsToCertificate",
+ "acm:DeleteCertificate",
+ "acm:DescribeCertificate",
+ "acm:ListTagsForCertificate",
+ "acm:RemoveTagsFromCertificate",
]
+ Effect = "Allow"
+ Resource = "arn:aws:acm:us-east-1:332355796717:certificate/*"
+ Sid = "ManageSiteViewerCertificate"
},
]
+ Version = "2012-10-17"
}
)
+ role = "github-actions-channel-project-site-infrastructure"
}
Plan: 1 to add, 0 to change, 0 to destroy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github-actions-channel-project-site-infrastructurerole to request and manage theus-east-1ACM viewer-certificate lifecycle required bychannel-project.acm:RequestCertificatedenial in the merged channel-project main apply.us-east-1certificate ARNs; retain the AWS-required wildcard resource only foracm:RequestCertificate.No linked issue.
Type of change
Validation
9e850faa33dd476c1f44c96c6c6ef452388d0a37.terraform-docsREADME update.RequestCertificaterequires wildcard scope; request tagging requiresAddTagsToCertificate; describe, list tags, remove tags, and delete use certificate ARNs.Impact and rollout
makeitworkcloud/channel-projectuses that role in its OpenTofu workflow.acm:RequestCertificate. No CloudFront alias or Cloudflare DNS record changed.github-actions-channel-project-site-infrastructure; it permits ACM request plus certificate lifecycle actions only inus-east-1for this AWS account. It does not request a certificate, alter CloudFront, or change DNS itself.Safety and secrets
AI assistance materially produced this change; reviewers should verify the role identity, action set, region/account certificate scope, and cross-repository retry gate.