fix: allow tfroot-twilio SOPS OIDC - #39
Merged
Merged
Conversation
Contributor
OpenTofu TestOpenTofu test passed. View run output |
Contributor
OpenTofu PlanOpenTofu plan passed. View run outputOpenTofu will perform the following actions:
[REDACTED: potentially sensitive plan output]
[REDACTED: potentially sensitive plan output]
~ assume_role_policy = jsonencode(
~ {
~ Statement = [
~ {
~ Condition = {
~ StringLike = {
[REDACTED: potentially sensitive plan output]
# (4 unchanged elements hidden)
"repo:makeitworkcloud@195502628/tfroot-namecheap@1349145005:*",
+ "repo:makeitworkcloud/tfroot-twilio:*",
]
}
# (1 unchanged attribute hidden)
}
# (3 unchanged attributes hidden)
},
]
# (1 unchanged attribute hidden)
}
)
[REDACTED: potentially sensitive plan output]
[REDACTED: potentially sensitive plan output]
tags = {
"ManagedBy" = "Terraform"
}
# (8 unchanged attributes hidden)
# (1 unchanged block hidden)
}
Plan: 0 to add, 1 to change, 0 to destroy.
OpenTofu will perform the following actions:
[REDACTED: potentially sensitive plan output]
[REDACTED: potentially sensitive plan output]
~ assume_role_policy = jsonencode(
~ {
~ Statement = [
~ {
~ Condition = {
~ StringLike = {
[REDACTED: potentially sensitive plan output]
# (4 unchanged elements hidden)
"repo:makeitworkcloud@195502628/tfroot-namecheap@1349145005:*",
+ "repo:makeitworkcloud/tfroot-twilio:*",
]
}
# (1 unchanged attribute hidden)
}
# (3 unchanged attributes hidden)
},
]
# (1 unchanged attribute hidden)
}
)
[REDACTED: potentially sensitive plan output]
[REDACTED: potentially sensitive plan output]
tags = {
"ManagedBy" = "Terraform"
}
# (8 unchanged attributes hidden)
# (1 unchanged block hidden)
}
Plan: 0 to add, 1 to change, 0 to destroy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow the existing multi-root
github-actions-sops-kmsrole to accept the exactmakeitworkcloud/tfroot-twiliorepository subject pattern. The bootstrap plan intfroot-twilioPR #1 currently fails before OpenTofu runs because that repository is not in the role trust policy.The added pattern is scoped to this one repository and matches the established standard-subject form already used by the existing OpenTofu roots. The role remains KMS-only; no S3 state access or Twilio API access is added.
Fixes # N/A — unblocks validation of the no-resource Twilio root bootstrap.
Type of change
Validation
The failed Twilio-root plan 33813787580 establishes the blocker:
sts:AssumeRoleWithWebIdentityis denied before the plan step. No local OpenTofu, SOPS, state, import, plan, or apply operations were run.Impact and rollout
Producer:
tfroot-awsowns the trust policy forgithub-actions-sops-kms.Consumer: only
tfroot-twiliois newly allowed to assume that existing KMS role. It remains unable to operate Twilio, read/write state through this change, or affect other repositories. After this PR's CI passes and an explicitly authorized merge applies it, rerun/replace the Twilio-root PR validation to confirm its no-resource plan. A later change still needs encrypted backend inputs and dedicated state access before any Twilio provider configuration.Rollback is a reviewed revert of this single subject entry; do not broaden to an organization wildcard.
Safety and secrets
AI agent materially produced this change; reviewers should confirm the single-repository scope and retained KMS-only permission boundary.