chore(ci): map chart updater app key for generated docs - #31
Merged
Conversation
Contributor
OpenTofu CI passedValidation output (redacted, last 12000 characters) |
Contributor
OpenTofu Plan |
xnoto
added a commit
that referenced
this pull request
Aug 30, 2026
## Summary - remove the `github-actions-opentofu-docs` IAM role and its inline Secrets Manager read policy ## Context The shared OpenTofu workflow's generated-docs commit path no longer uses AWS: makeitworkcloud/shared-workflows#33 sources the chart updater GitHub App key from the caller-mapped `CHART_UPDATER_GITHUB_APP_PRIVATE_KEY` Actions secret, provisioned by makeitworkcloud/tfroot-github#45. After those land, nothing references this role or the legacy Secrets Manager copy, matching `tfroot-github/docs/chart-updater-github-app.md`. This mirrors #30, which removed the charts-facing role. The manually created Secrets Manager secret (`xnoto-s-chart-updater-github-app-private-key-*`) is intentionally not deleted here; per the runbook its deletion is a separate approved cleanup after the agreed rollback window. ## Rollout dependency Draft until all of the following have merged and applied: 1. makeitworkcloud/shared-workflows#33 2. makeitworkcloud/tfroot-github#45 3. Caller PRs: #31, tfroot-cloudflare#37, tfroot-gcp#5, tfroot-github#46, tfroot-libvirt#26 Destroying this role before then breaks generated-docs commits on same-repository PRs. ## Validation - GitHub Actions OpenTofu test and plan are required before merge; the plan must show only the role and policy destruction. - Reviewed the diff: file deletion only; no credentials or decrypted values included. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CHART_UPDATER_GITHUB_APP_PRIVATE_KEYActions secret into the reusable OpenTofu workflowContext
Completes the chart updater App key migration for this root. makeitworkcloud/shared-workflows#33 replaces the AWS OIDC + Secrets Manager docs-commit credential with this secret; makeitworkcloud/tfroot-github#45 provisions the secret to this repository.
Merge order
CI on this PR calls the reusable workflow from
@mainand cannot pass until shared-workflows#33 merges; re-run checks after that lands.Validation