fix(opentofu): commit automatic pre-commit fixes - #38
Merged
Conversation
Shared Workflows CIShared workflows CI passed. View run output |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Run the canonical auto-fixing pre-commit hooks before validation and commit their tracked changes to same-repository pull-request branches through the existing GitHub App token. This extends the existing Terraform-docs behavior to
terraform_fmt, end-of-file, line-ending, and trailing-whitespace fixes without changing the reusable workflow interface.No linked issue.
Type of change
Validation
CI is the validation environment. No local OpenTofu operation was run. The PR check validates workflow syntax and this repository's pre-commit configuration; it cannot exercise a consumer pull request that receives an autofix.
Impact and rollout
Canonical producer:
makeitworkcloud/shared-workflows/.github/workflows/opentofu.yml. On merge, existing callers that reference@mainreceive the behavior on future runs; current source was checked intfroot-aws,tfroot-cloudflare,tfroot-gcp,tfroot-github,tfroot-libvirt, andtfroot-namecheap. Each maps the existingCHART_UPDATER_GITHUB_APP_PRIVATE_KEY; no caller changes are required.The workflow still commits only on same-repository pull requests with that key. Forks and runs without the key fail on detected drift; pushes to
maindo not auto-commit and remain blocked before apply. Inputs, permissions, runner label, plan behavior, and environment-gated apply behavior are unchanged. Merging is the remaining gate; no artifact publication, GitOps selection, reconciliation, or runtime rollout is involved.Safety and secrets
AI-assisted change. Agent-knowledge topology revision consulted:
f3f7228652495d1082bfbdb6f06de7c6ebf1224b. Material producer/consumer relationships were re-verified against current repository guidance and caller workflows.