Skip to content

fix(opentofu): surface validation step failures #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xnoto merged 1 commit into from
Aug 30, 2026
Merged

fix(opentofu): surface validation step failures #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 5 additions & 16 deletions .github/workflows/opentofu.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,25 +95,21 @@ jobs:
}
- name: Checkout
id: checkout
continue-on-error: true
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
fetch-depth: 0
persist-credentials: false
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name == github.repository && github.event.pull_request.head.ref || github.sha }}
- name: Fetch canonical pre-commit config
id: fetch-config
continue-on-error: true
run: |
curl -sSL -o .pre-commit-config.yaml \
https://raw.githubusercontent.com/makeitworkcloud/images/main/tfroot-runner/pre-commit-config.yaml
- name: Initialize OpenTofu
id: initialize
continue-on-error: true
run: tofu init -backend=false
- name: Generate Terraform docs
id: terraform-docs
continue-on-error: true
run: |
set -euo pipefail
set +e
Expand Down Expand Up @@ -147,7 +143,6 @@ jobs:
exit 0
- name: Require GitHub App key for generated Terraform docs
id: terraform-docs-key
continue-on-error: true
if: >-
steps.terraform-docs.outcome == 'success' &&
steps.terraform-docs.outputs.changed == 'true' &&
Expand Down Expand Up @@ -193,7 +188,11 @@ jobs:
git push "https://x-access-token:${GITHUB_APP_TOKEN}@github.com/${GITHUB_REPOSITORY}.git" "HEAD:$PR_HEAD_REF"
- name: Run tests
id: validation
continue-on-error: true
if: >-
always() &&
steps.checkout.outcome == 'success' &&
steps.fetch-config.outcome == 'success' &&
steps.initialize.outcome == 'success'
run: |
set -o pipefail
SKIP=no-commit-to-branch pre-commit run -a --color=never 2>&1 | tee validation-output.txt
Expand Down Expand Up @@ -248,16 +247,6 @@ jobs:
} else {
await github.rest.issues.createComment({ owner: context.repo.owner, repo: context.repo.repo, issue_number: context.issue.number, body });
}
- name: Mark validation failed
if: >-
always() &&
(steps.checkout.outcome == 'failure' ||
steps.fetch-config.outcome == 'failure' ||
steps.initialize.outcome == 'failure' ||
steps.terraform-docs.outcome == 'failure' ||
steps.terraform-docs-key.outcome == 'failure' ||
steps.validation.outcome == 'failure')
run: exit 1

plan:
permissions:
Expand Down