fix: isolate OpenTofu plan comment capture - #35
Merged
Conversation
Shared workflows CI passedValidation output (redacted, last 12000 characters) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix corrupted OpenTofu plan PR comments by giving the reusable workflow its own capture file. Consumer Makefiles continue to write
plan-output.txt; the workflow now writes and readsplan-capture.txt, preventing concurrent truncating writers from producing sparse-file NUL holes.The primary comment extraction now ends at the first
Plan:summary, excluding the duplicate human-readable rendering emitted bytofu show. Atr -d '\000'stage removes malformed embedded NUL bytes before the existing ANSI stripping and sensitive-output redaction pipeline.Validation
.github/workflows/opentofu.ymlchanged (7 additions, 6 deletions).tfroot-github,tfroot-aws,tfroot-libvirt, andtfroot-cloudflareMakefiles each writeplan-output.txtfromtofu show.No consumer workflow references, markers, comment lifecycle, inputs, permissions, output cap, action pins, or redaction rules were changed.