Skip to content

fix: use Bash in containerized OpenTofu jobs - #31

Merged
xnoto merged 3 commits into
mainfrom
fix/public-tf-runners
Aug 28, 2026
Merged

fix: use Bash in containerized OpenTofu jobs#31
xnoto merged 3 commits into
mainfrom
fix/public-tf-runners

Conversation

@xnoto

@xnoto xnoto commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Summary

Linear: No ticket — the arc-tf outage migration exposed GitHub container jobs defaulting to sh; the reusable workflow uses Bash-only pipefail.

Run containerized OpenTofu jobs with Bash.

Implementation Details

  • Set defaults.run.shell to bash for test, plan, and apply jobs.

Testing

  • Parsed .github/workflows/opentofu.yml as YAML.
  • Ran git diff --check.
  • GitHub Actions CI pending.

Rollback and operational impact

  • Revert the shell defaults to restore runner-default shells.
  • No infrastructure resources change.

Completion Status

  • Fully addresses the verified requirements

@xnoto
xnoto requested a review from a team as a code owner August 28, 2026 05:18
# Conflicts:
#	.github/workflows/opentofu.yml
@github-actions

Copy link
Copy Markdown

Shared workflows CI passed

View the workflow run.

Validation output (redacted, last 12000 characters)

[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/gitleaks/gitleaks.
[INFO] Initializing environment for https://github.com/rhysd/actionlint.
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/gitleaks/gitleaks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/rhysd/actionlint.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
check for case conflicts.................................................Passed
check for merge conflicts................................................Passed
check for broken symlinks............................(no files to check)Skipped
check vcs permalinks.....................................................Passed
detect destroyed symlinks................................................Passed
detect private key.......................................................Passed
mixed line ending........................................................Passed
trim trailing whitespace.................................................Passed
Detect hardcoded secrets.................................................Passed
Lint GitHub Actions workflow files.......................................Passed

@xnoto
xnoto merged commit 123f5b4 into main Aug 28, 2026
1 check passed
@xnoto
xnoto deleted the fix/public-tf-runners branch August 28, 2026 05:22
@xnoto xnoto mentioned this pull request Aug 28, 2026
1 task
xnoto added a commit that referenced this pull request Aug 28, 2026
## Summary
Linear: No ticket — reverting the containerized OpenTofu runner
migration so infrastructure recovery can proceed manually.

Revert the optional job-container interface and Bash defaults introduced
by PRs #30 and #31.

## Implementation Details
- Remove the `container-image` reusable-workflow input.
- Remove job container and shell defaults from test, plan, and apply.

## Testing
- Parsed `.github/workflows/opentofu.yml` as YAML.
- Ran `git diff --check`.

## Rollback and operational impact
- Revert this PR to restore optional job-container support.
- No infrastructure resources change.

## Completion Status
- [x] Fully reverts the merged runner-container changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant