Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion opencode-sms-bridge/server.py
Original file line number Diff line number Diff line change
Expand Up @@ -502,7 +502,7 @@ def create_session(self, agent: str) -> str:
return session_id

def prompt(self, session_id: str, parts: list[dict[str, str]]) -> str:
response = self._request(f"/api/session/{session_id}/message", {"parts": parts})
response = self._request(f"/session/{session_id}/message", {"parts": parts})
data = response.get("data", response)
candidates = data.get("parts", []) if isinstance(data, dict) else []
text = "".join(part.get("text", "") for part in candidates if part.get("type") == "text")
Expand Down
17 changes: 14 additions & 3 deletions opencode-sms-bridge/test_server.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import tempfile
import unittest
from pathlib import Path
from unittest.mock import patch

from cryptography.fernet import Fernet
from fastapi.testclient import TestClient
Expand All @@ -12,6 +13,7 @@

from server import (
BridgeError,
OpenCodeClient,
Routing,
SQLiteStore,
Settings,
Expand Down Expand Up @@ -115,19 +117,28 @@ def test_ingress_accepts_signed_approved_message_once(self):
self.assertIsNotNone(self.store.claim())
self.assertIsNone(self.store.claim())

def test_ingress_ignores_unapproved_sender_after_signature_validation(self):
def test_ingress_ignores_unapproved_sender_before_queueing(self):
form = {"AccountSid": "AC1234567890", "MessageSid": "SM124", "From": "+15558888888", "To": "+15550000001", "Body": "hello", "NumMedia": "0"}
signature = RequestValidator("auth-token").compute_signature(self.settings.canonical_webhook_url, form)
client = TestClient(create_ingress_app(self.settings, self.store))
with self.assertLogs("opencode-sms-bridge", level="INFO") as captured:
response = client.post("/twilio/inbound", data=form, headers={"X-Twilio-Signature": signature})
with patch.object(self.store, "enqueue", wraps=self.store.enqueue) as enqueue:
with self.assertLogs("opencode-sms-bridge", level="INFO") as captured:
response = client.post("/twilio/inbound", data=form, headers={"X-Twilio-Signature": signature})
telemetry = "\n".join(captured.output)
self.assertEqual(response.status_code, 200)
self.assertIn("event=inbound_ignored reason=account-destination-or-sender", telemetry)
for unsafe_value in (form["From"], form["To"], form["MessageSid"], form["Body"]):
self.assertNotIn(unsafe_value, telemetry)
enqueue.assert_not_called()
self.assertIsNone(self.store.claim())

def test_prompt_uses_compatible_session_message_route(self):
parts = [{"type": "text", "text": "hello"}]
client = OpenCodeClient(self.settings)
with patch.object(client, "_request", return_value={"parts": [{"type": "text", "text": "reply"}]}) as request:
self.assertEqual(client.prompt("ses_123", parts), "reply")
request.assert_called_once_with("/session/ses_123/message", {"parts": parts})

def test_image_sanitization_removes_exif(self):
image = Image.new("RGB", (8, 8), color="red")
original = tempfile.SpooledTemporaryFile()
Expand Down
Loading