feat: harden cflan for public review - #11
Merged
Merged
Conversation
The builtins.open patch passes an explicit new= mock, so it injects no argument; the extra '_' parameter was treated as a missing pytest fixture.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardens the NetworkManager-to-Cloudflare DNS update path while preserving the existing root/volume configuration contract.
/cflan_vars.yamland/cflan_sops_vars.yamlnames, while retaining/vars.yamland/sops_vars.yamlas supported aliases;Fixes: N/A (review-driven hardening)
Type of change
Validation
CI is the validation authority. No workstation installation, NetworkManager hook, SOPS decryption, or live Cloudflare DNS update was run. PR checks must validate tests, mypy, hooks, and package build/install.
Impact and rollout
Canonical producer:
makeitworkcloud/cflan; no in-organization source consumer was found. This PR changes authored source only.The installed-path compatibility contract is preserved: an existing root/volume
/vars.yamlor/sops_vars.yamlremains readable. A future installation may instead supply the preferred matching/cflan_vars.yamlor/cflan_sops_vars.yaml. Publishing this PR does not install the new script, alter a root-volume file, invoke NetworkManager, or change a Cloudflare DNS record. Installation and functional verification remain manual, separate stages.Safety and secrets
Rollback is a source rollback before a later installation. The existing root-volume aliases remain supported to prevent an immediate configuration migration. This change was materially produced by an AI agent and requires normal maintainer review.