Repository navigation
fix: distinguish shell tasks from subagent progress - #242
Merged
Merged
Conversation
Signed-off-by: Tiberiu Socaci <tsocaci@makeitfuture.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude SDK task lifecycle events include shell commands as well as subagents. A
local_bashtask previously produced an agent activity row and the native “Coordinating agents” status. Preserve explicit non-agent classification across subsequent untyped lifecycle frames and late aliases, while retaining ordinary tool events, genuine local/remote agents and legacy Agent/Task events.Validation: 109 focused assertions pass, including foreground/background Bash lifecycle negatives, interleaved real agent controls, legacy aliases, and the parser-to-Slack status path with a Codex command control. Exact-head coverage: 4,472 passed, 0 failed, 10 opt-in skips; actual container-runtime checks: 14 passed, 0 skipped, unchanged resource inventory. Static, full-history secret scan, security coverage, production audit, DCO and release artifacts all exited 0. GitHub CI and coordinator landing remain pending. FEATURES, TEST-PLAN and CHANGELOG document the behavior and live gate.
The official SDK task-type contract and isolated parser repro establish this defect. A prior native shell-only misleading label is corroborating evidence; its unretained raw event shape and loaded revision are not attributed to this candidate. Private dual-engine acceptance definition is proposed separately; no fresh deployed PASS or restart is claimed.