Repository navigation
fix: show readable background continuation errors - #241
Merged
Merged
Conversation
Signed-off-by: Tiberiu Socaci <tsocaci@makeitfuture.com>
Signed-off-by: Tiberiu Socaci <tsocaci@makeitfuture.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a background job finished but its Claude follow-up failed with a nested provider response, the thread displayed the JSON document. Format only the public notice through the existing provider-sentence formatter; retain structured engine facts, redacted audit detail and the guard against replaying interrupted work.
Decode without truncation, redact again, then bound the public sentence to 400 characters so a length limit cannot expose a secret prefix. The integration regression runs actual spawned fixture CLIs through both engine parsers, runMessage and BackgroundJobs, covering ordinary, long and JSON-escaped error values plus delivery recovery without replay. Runtime and transport boundaries are fixtures; no live provider or Slack-client acceptance is claimed.
Validation: original Claude JSON regression reproduced; independent review's truncation regression reproduced for both engines; corrected focused 19 tests passed. Exact-head full regression: 4468 passed, zero failed; 10 opt-in skips separately covered by 14 real runtime checks with zero skips and no resource delta. Static, history secret scan, security coverage, production dependency audit, DCO and release artifact checks all passed. Fresh original acceptance harness: 2 passed with exact source hashes. The superseded initial commit and its evidence remain in history. Targets beta; no stable promotion or runtime restart.