Repository navigation
Preserve container job exit codes in completion audit - #240
Merged
Merged
Conversation
Signed-off-by: Tiberiu Socaci <tsocaci@makeitfuture.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Container background jobs parse their durable exit marker but passed only the semantic outcome into completion handling. This left bg_finish.exitCode null even for confirmed exits such as 0 and 23. Forward the parsed code to the existing audit field; missing markers remain unknown. Completion notices, internal continuation prose and the pending-delivery schema are unchanged.
A real BackgroundJobs wrapper/poller regression fails before the fix and passes after it. It covers exits 0/23 and a missing marker with deterministic probe gating, plus semantic output, single delivery and cleanup. The final-base focused suite passes 59 tests with zero skips, including placeholder redaction and secret-host approval continuation.
Updated FEATURES.md, TEST-PLAN.md and CHANGELOG.md. Full exact-commit local gates pass: 4,462 regression tests, zero failures; ten opt-ins separately exercised by 14 actual container checks with zero skips and no retained resources. Static checks, history secret scan, security coverage, production dependency audit, DCO and release artifacts all pass. The fresh exit-23 integration retest also passes. Independent review and GitHub CI remain prerequisites for coordinator-controlled beta landing. No global restart or live acceptance claim.