Repository navigation
Redact hidden proxy placeholders in background job logs - #238
Merged
Merged
Conversation
Signed-off-by: Tiberiu Socaci <tsocaci@makeitfuture.com>
makeitfutureDev
force-pushed
the
fix/background-placeholder-redaction
branch
from
November 6, 2026 19:51
6517aa8 to
8fc2214
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proxy-mode background shells receive hidden credentials as placeholders. The detached log wrapper selected protected environment names by matching real credential values, which omitted those placeholders. Select them using the resolver’s explicit placeholder-name metadata as well as the existing hidden-value match. Readable configuration remains visible, and daemon-side credential redaction is unchanged.
A full BackgroundJobs integration regression failed on the original source and now passes: actual resolver, shell wrapper, full and split stdout/stderr output, durable log, status, continuation and cleanup. The final-base focused suite passes 56 tests with zero skips, including the previously landed DST regression. Full coverage passes 4,461 tests with zero failures; ten opt-ins are separately exercised by 14 actual container checks with zero skips and no resource delta. Static checks, history secret scan, security coverage, production audit, DCO and release artifacts all pass. Exact-commit private integration retest also passes. Independent review and GitHub CI remain prerequisites for coordinator-controlled beta landing.
Updated FEATURES.md, TEST-PLAN.md and CHANGELOG.md. This fixes placeholder output filtering; no real credential disclosure was observed.
Refreshed onto beta commit 23dcbfd after the separately reviewed secret-server approval continuation landed. Both changes and documentation entries are preserved. All local gates, actual runtime checks and the private integration retest above were rerun on exact head 8fc2214.