Repository navigation
refactor: remove unused imports and unreachable code (Periphery pass) - #50
Merged
Merged
Conversation
Code that nothing reaches, found with Periphery (--retain-public). No public API, behaviour, fixture or tolerance changes. - 9 unused imports (2 in Sources, 7 in the parity tests) - MetalExecutable.output, a stored field that was always the empty array and never read - the count argument of the private filterAxis, which the function never read Periphery: 17 findings before, 6 after; the rest are fixture fields, GPU parameter blocks, public API or documented. Done: the dead-code pass for this repo, full test suite green. Next: a PR check against a Periphery baseline so new dead code is caught. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Paul
What and why
Removes code that nothing reaches, found with Periphery (
--retain-public, the weekly scan's own command). No public API changes, no behaviour changes, no fixture or tolerance is touched.MetalExecutable.output, a stored field that was always the empty array and never readcountargument of the privatefilterAxis, which the function never readPeriphery findings: 17 before, 6 after. What is left is not dead code:
beamargument of the publicDetector.shape(for:beam:)requirement and its four conformances (public API)lobatoTableSourceSHA256, written bytools/pins/potential-multislice/pins.pywith the table (provenance)How it was checked
swift test -c release: 0 failures (full suite with the parity tests, on the Mac)--strictand SwiftFormat 0.64.4--lintpass🤖 Generated with Claude Code