Repository navigation
test: re-pin the EDS session's fitted areas for SpectroKit 0.13 - #66
Merged
Merged
Conversation
MacEMUI takes SpectroKit by range, and CI now resolves 0.13.x, where the continuum step at the absorption edges is broadened by the detector resolution by default (SpectroKit#65). The pooled fit's areas on the planted spectrum moved: Al 987084.187148377 -> 987248.6317845077 Mg 49511.781907676865 -> 49506.708818394676 Si 9741.175285607535 -> 9730.952542984644 All three stay within the 3 % bound of the planted areas. The values are the ones CI printed on run 41346127643 (macos-26, Xcode 26.6). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VkKZEWLQDNR7GTJSa5geSZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EDXSessionTests.testQuantifyEqualsTheKitAndRecoversThePlantedAreasfails on main and on Dependabot #64. MacEMUI takes SpectroKit by range, and CI now resolves 0.13.x. In 0.13 the continuum step at the absorption edges is broadened by the detector resolution by default (SpectroKit#65), so the pooled fit's areas on the planted spectrum moved. Paul approved the re-pin on 2 Nov.Before / after
All three stay inside the test's 3 % bound of the planted areas. The new values are exactly the ones CI printed on run 41346127643 (macos-26, Xcode 26.6). The test's other asserts (the room equals the kit's direct call, at% sums to 100) passed there unchanged. Only the test file changes.
Checks
testjobs on CI (no Swift toolchain in the cloud session that wrote this; CI is the check)Unblocks Dependabot #64.
Generated by Claude Code