Repository navigation
release: v0.9.4, and check the tag before publishing - #8
Merged
Merged
Conversation
Ships the striper fix. release.yml now stops before building or publishing if the release tag doesn't match the version files, because a wrong tag can't be moved or deleted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the version to 0.9.4 and adds a release tag check. Pushing the tag after this merges publishes the striper fix, which is on
mainbut unreleased.Changes
control-plane/Cargo.toml,Cargo.lock(this package's entry only),client-py/pyproject.toml,client-py/hypercache/__init__.pyand the default tag inrelease.yml.Unreleasedbecomes0.9.4, and the CI script fix and the tag check are added.check-release-tagjob inrelease.ymlruns first and compares the tag with the three version files. Every other job depends on it, so a mismatch stops the release before anything is built or published. Tags can't be moved or deleted, so the number is still used up.Testing
v0.9.4passed, andv0.9.3,v0.9.4-rc1,0.9.4andmainfailed as intended. The job itself first runs on GitHub when the tag is pushed.imageandk8sstages with a temporaryBUILDX_CONFIG, and both passed.After merging
Once CI passes on the commit in
main, tag it:git tag v0.9.4 <commit> && git push origin v0.9.4. Merge #7 too, since it documents these rules.