Skip to content

Update sources.json - #2700

Open
ibrahimsif6-netizen wants to merge 10 commits into
lnreader:masterfrom
ibrahimsif6-netizen:patch-1
Open

ibrahimsif6-netizen wants to merge 10 commits into
lnreader:masterfrom
ibrahimsif6-netizen:patch-1

Conversation

@ibrahimsif6-netizen

Copy link
Copy Markdown

Checklist

  • Update version code if an existing plugin was modified
  • Test changes in Plugin Playground or the app
  • Reference related issues in the PR body (e.g. Closes #xyz)
  • Commit messages follow type(scope): description (e.g. feat(<generator>): add new source)

@greptile-apps

greptile-apps Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 3/5

[Low impact] Updates a URL in plugin configuration data.

Restore the comma and increase the Novels Paradise version before merging.

Findings

  1. P1 LightNovelWP plugins fail to generate ▶
  2. P1 URL fix keeps old version ▶

Summary

Changes the Novels Paradise base URL to https://novelsparadise.site/np-light/.

  • Novels Paradise now uses its /np-light/ address.

Reviews (1) · Last reviewed commit: "Update sources.json" · Reviewed by Greptile

{
"id": "novelsparadise",
"sourceSite": "https://novelsparadise.site/",
"sourceSite": "https://novelsparadise.site/np-light/"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 LightNovelWP plugins fail to generate

The changed sourceSite line is missing its trailing comma, making sources.json invalid JSON. generator.js imports this file before generating any plugins, so the entire LightNovelWP family is skipped. After build:full cleans the generated files, none of those plugins are regenerated. Restore the comma.

Suggested change
"sourceSite": "https://novelsparadise.site/np-light/"
"sourceSite": "https://novelsparadise.site/np-light/",

Knowledge Base Used: Multi-source plugin generation

{
"id": "novelsparadise",
"sourceSite": "https://novelsparadise.site/",
"sourceSite": "https://novelsparadise.site/np-light/"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 URL fix keeps old version

The URL changes without increasing options.versionIncrements, so Novels Paradise still builds as 1.1.12. Even after fixing the comma, build-plugin-manifest.js skips this changed plugin under --only-new when the existing version is the same. Add versionIncrements: 1 so the URL fix has a newer version, as the family’s author guide requires for URL changes.

Knowledge Base Used: Multi-source plugin generation

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant