Repository navigation
Conversation
[Medium impact] Adds pagination loop detection to a novel-scraping plugin. The PR appears safe to merge, with a non-blocking improvement to keep page history separate for each listing. Findings
SummaryAdds repeated-page detection to
Reviews (1) · Last reviewed commit: "fix duplication for novel pages" · Reviewed by Greptile |
4 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
readnovelfull multisrc only stops loading pages when a page comes back empty but most sites (FWN, allnovelfull, etc) either redirect to the last page or keep showing the last page with updated url. So I added a check that fetching next page stops if the previous fetch and current fetch has same items
Required for #2694
Checklist
type(scope): description(e.g.feat(<generator>): add new source)