Skip to content

fix(readnovelfull): stop fetching next page when a site repeats the last page - #2693

Open
D3ICIDE wants to merge 3 commits into
lnreader:masterfrom
D3ICIDE:FWN
Open

D3ICIDE wants to merge 3 commits into
lnreader:masterfrom
D3ICIDE:FWN

Conversation

@D3ICIDE

@D3ICIDE D3ICIDE commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

readnovelfull multisrc only stops loading pages when a page comes back empty but most sites (FWN, allnovelfull, etc) either redirect to the last page or keep showing the last page with updated url. So I added a check that fetching next page stops if the previous fetch and current fetch has same items

Required for #2694

Checklist

  • Update version code if an existing plugin was modified
  • Test changes in Plugin Playground or the app
  • Reference related issues in the PR body (e.g. Closes #xyz)
  • Commit messages follow type(scope): description (e.g. feat(<generator>): add new source)

Copilot AI balanced review requested due to automatic review settings October 17, 2026 10:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@greptile-apps

greptile-apps Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 4/5

[Medium impact] Adds pagination loop detection to a novel-scraping plugin.

The PR appears safe to merge, with a non-blocking improvement to keep page history separate for each listing.

Findings

  1. P2 Different listings share page history ▶

Summary

Adds repeated-page detection to popularNovels for the ReadNovelFull family.

  • ReadNovelFull stops when consecutive pages repeat the same novels.

Reviews (1) · Last reviewed commit: "fix duplication for novel pages" · Reviewed by Greptile

Comment thread plugins/multisrc/readnovelfull/template.ts
@D3ICIDE D3ICIDE changed the title fix(readnovelfull): stop pagination when a site repeats the last page fix(readnovelfull): stop fetching next page when a site repeats the last page Oct 17, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants