Update go deps (major) - #298
Conversation
0761405 to
d4e18d9
Compare
c3a5dc4 to
d7194fc
Compare
d7194fc to
10c684a
Compare
7c45c97 to
c84645f
Compare
c84645f to
a2d3f0d
Compare
a2d3f0d to
8ddadd8
Compare
66dc19e to
21debac
Compare
f4500a0 to
49a52d4
Compare
49a52d4 to
0eeaa00
Compare
0eeaa00 to
bc10633
Compare
bc10633 to
4db28b2
Compare
ae5a207 to
13b4e9b
Compare
13b4e9b to
ee7740b
Compare
ee7740b to
99cbc06
Compare
dc1aa0f to
794fe86
Compare
794fe86 to
eb6b781
Compare
|
eb6b781 to
921c90f
Compare
921c90f to
4cddf0a
Compare
7ca1b50 to
26a9c62
Compare
8e4f624 to
4e83c61
Compare
ebfd16e to
3b89039
Compare
3b89039 to
aa38f35
Compare
b83c60a to
46f1946
Compare
21bf2c5 to
3652766
Compare
391142a to
ea4e612
Compare
ea4e612 to
a2dc1c3
Compare
a2dc1c3 to
79eb0c0
Compare
79eb0c0 to
d9540a4
Compare
| github.com/pion/rtp v1.10.2 | ||
| github.com/mjibson/go-dsp v1.0.0 | ||
| github.com/ory/dockertest/v4 v4.0.0 | ||
| github.com/pion/rtp/v2 v2.0.0 |
There was a problem hiding this comment.
🔴 Dependency version bumps leave the project unbuildable
The dependency list is switched to new major versions (github.com/ory/dockertest/v4, github.com/pion/rtp/v2 at go.mod:19-20) while all source files still use the old versions and the checksum file was never refreshed, so the project can no longer be built or tested.
Impact: Builds and tests fail immediately for everyone until the code and checksum file are updated.
Stale imports and missing go.sum entries after the major-version bumps
go.modnow requiresgithub.com/ory/dockertest/v4 v4.0.0andgithub.com/pion/rtp/v2 v2.0.0, but the code still imports the previous major versions:test/integration/docker_test.go:11,test/integration/docker_mac_test.go:12,test/integration/livekit_test.go:10-11(github.com/ory/dockertest/v3), andpkg/media/rtpconn/conn.go:25,pkg/sip/media.go:24(github.com/pion/rtp). Those module paths are no longer listed as requirements, so resolution fails.go.sumwas not regenerated: it still contains onlygithub.com/ory/dockertest/v3 v3.12.0,github.com/pion/rtp v1.10.2andgithub.com/mjibson/go-dsp v0.0.0-20180508042940-...(go.sum:149-150,177-178,197-198); there are no hashes forgithub.com/pion/rtp/v2 v2.0.0,github.com/ory/dockertest/v4 v4.0.0, orgithub.com/mjibson/go-dsp v1.0.0, which causes "missing go.sum entry" errors.- Note also that transitive dependencies (e.g.
pion/webrtc/v4,pion/interceptor,livekit/media-sdk) still depend ongithub.com/pion/rtpv1, so both majors would need to coexist; simply swapping the requirement is not sufficient.
Was this helpful? React with 👍 or 👎 to provide feedback.
| github.com/ory/dockertest/v3 v3.12.0 | ||
| github.com/pion/rtp v1.10.2 | ||
| github.com/mjibson/go-dsp v1.0.0 | ||
| github.com/ory/dockertest/v4 v4.0.0 |
There was a problem hiding this comment.
🔴 Docker test library import path mismatch causes test build failure
The dependency declaration was bumped to a new major version (github.com/ory/dockertest/v4 at go.mod:19) without updating the corresponding import paths in test files, so integration tests will fail to compile.
Impact: All integration tests cannot be built or run.
Import path mismatch details
The go.mod now declares github.com/ory/dockertest/v4 v4.0.0 but the old github.com/ory/dockertest/v3 was removed. Three test files still use the old v3 import path:
test/integration/docker_test.go:11imports"github.com/ory/dockertest/v3"test/integration/livekit_test.go:11imports"github.com/ory/dockertest/v3"test/integration/livekit_test.go:12imports"github.com/ory/dockertest/v3/docker"test/integration/docker_mac_test.go:12imports"github.com/ory/dockertest/v3"
These imports need to be updated to "github.com/ory/dockertest/v4" (and v4/docker) to match the module path declared in go.mod.
Prompt for agents
The go.mod was updated to use github.com/ory/dockertest/v4 v4.0.0 but the test source code still imports github.com/ory/dockertest/v3. Four import statements across three files need updating:
1. test/integration/docker_test.go line 11: change v3 to v4
2. test/integration/livekit_test.go line 11: change v3 to v4
3. test/integration/livekit_test.go line 12: change v3/docker to v4/docker
4. test/integration/docker_mac_test.go line 12: change v3 to v4
Also verify that the dockertest v4 API is compatible with how the Pool type and other APIs are used in these test files.
Was this helpful? React with 👍 or 👎 to provide feedback.
| github.com/mjibson/go-dsp v0.0.0-20180508042940-11479a337f12 | ||
| github.com/ory/dockertest/v3 v3.12.0 | ||
| github.com/pion/rtp v1.10.2 | ||
| github.com/mjibson/go-dsp v1.0.0 |
There was a problem hiding this comment.
🔴 Build fails because dependency checksums were not updated
The go-dsp dependency version is changed to v1.0.0 (go.mod:18) but no matching checksum entry exists in the module checksum file, so the build fails with a missing checksum error.
Impact: The project fails to build/verify until the checksum file is regenerated.
go.sum not regenerated for go-dsp v1.0.0
go.mod:18 now requires github.com/mjibson/go-dsp v1.0.0, but go.sum still only contains the old pseudo-version v0.0.0-20180508042940-11479a337f12 and has no v1.0.0 entry. go build/go mod verify will fail with a missing go.sum entry. The import path is unchanged (github.com/mjibson/go-dsp/fft at pkg/audiotest/freq.go:23), so only go.sum needs regenerating via go mod tidy.
Prompt for agents
go.mod bumped github.com/mjibson/go-dsp to v1.0.0, but go.sum was not regenerated and lacks a v1.0.0 entry (it still only has the old pseudo-version). Run go mod tidy to update go.sum. The import path is unchanged so no source edits are needed.
Was this helpful? React with 👍 or 👎 to provide feedback.
Generated by renovateBot
This PR contains the following updates:
v0.0.0-20180508042940-11479a337f12→v1.0.0v3.12.0→v4.0.0v1.10.5→v2.0.0Release Notes
ory/dockertest (github.com/ory/dockertest/v3)
v4.0.0Compare Source
What's Changed
New Contributors
Full Changelog: ory/dockertest@v3.12.0...v4.0.0
pion/rtp (github.com/pion/rtp)
v2.0.0Compare Source
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.