fix: move sideways across the window cards of the session menu - #133
Open
nextestudios wants to merge 2 commits into
Open
nextestudios wants to merge 2 commits into
nextestudios wants to merge 2 commits into
Conversation
Left/right between the open-window cards now picks the neighbour on the same row by position instead of relying on the XY focus search, which could miss it (cards scaled while focused, clipped by the scrolling panel). The end of a row is an end, and Left on the first column still goes back to the side panel. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Sideways card navigation: Left/Right on a focused window card selects the nearest card on the same row by position, brings it into view, and consumes Right at the row end while preserving the existing Left-to-sidebar behavior.
- Validation notes: Added paired changelog entries and manual test coverage for single- and multi-row card navigation.
GPT Luna | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
In the session menu (overlay), moving sideways across the open-window cards could fail: left/right relied on the XY focus search alone, which can miss the neighbouring card (cards are scaled while focused and the grid is clipped by the scrolling panel).
MoveAcrossWindowCardsinSessionMenuWindow: Left/Right on a window card picks the neighbour on the same row by position (the closest X on that side) and brings it into view. It runs after the existing "Left on the first column goes back to the side panel" rule and before the explicit "Right from the side panel enters the grid" rule from fix: restore DualShock navigation and release alpha 5 #130, so both keep working.docs/TESTING.md: the sideways checks across one and several rows.Validation
docs/TESTING.md.dotnet testare left to CI.🤖 Generated with Claude Code