Repository navigation
fix(linbo-remote): name a surplus field instead of an unknown empty command - #197
Merged
Merged
Conversation
…ommand "image_name:1:win11-test" took "1" as image name and then parsed the rest ":win11-test" as a command without a name, which gave the misleading 'Command "" is not known!'. Any field more than a command takes now raises 'Unexpected ":win11-test" after "image_name:1"!' instead, the same for e.g. "sync:1:x". The help of image_name now says explicitly that it takes only the name and must come before the image commands. README.md gets the image_name command in the linbo-remote help and a section about images under a new name. Refs #133 Signed-off-by: thomas@linuxmuster.net Assisted-by: Claude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #196 (#133), found while testing on lmnsrv1:
linbo-remote -p create_image:1,upload_image:1,image_name:1:win11-test -i multi-1failed with the misleadingCommand "" is not known!: the parser took1as image name and then read:win11-testas a command without a name.Unexpected ":win11-test" after "image_name:1"!(same for e.g.sync:1:x,reboot:1).image_namehelp: takes only the name, no position number, and must come before the image commands.image_namein the linbo-remote help block, a "New in 7.4.21" note, and a new section "Images under a new name" (client commands, qcow2 only,sourceimage, takeover of reg/postsync/prestart, overwrite protection, registered devices, old images withoutsourceimage).Correct form of the command above:
linbo-remote -i multi-1 -p image_name:win11-test,create_image:1,upload_image:1Test plan
tests/python139 passed (5 new cases for surplus fields)printUsage()output🤖 Generated with Claude Code