chore: update quickPlugins config permissions and serial - #1709
Open
18202781743 wants to merge 1 commit into
Open
chore: update quickPlugins config permissions and serial#170918202781743 wants to merge 1 commit into
18202781743 wants to merge 1 commit into
Conversation
1. Change the quickPlugins permission from readonly to readwrite 2. Increment the config serial from 0 to 1 to reflect the change 3. This enables dynamic customization of quick panel plugins by users or third-party extensions 4. The previous readonly restriction prevented modification of the quick panel plugin order and configuration Log: 快捷面板插件支持自定义配置 Influence: 1. Verify quickPlugins config can be modified via dconfig or D-Bus 2. Test that changes to the plugin list are persisted after reboot 3. Check that the quick panel still displays plugins in the specified order 4. Test restoring default values if needed 5. Ensure the configuration change doesn't break existing plugin functionality chore: 更新快捷面板插件配置权限和序列号 1. 将 quickPlugins 的权限从 readonly 改为 readwrite 2. 将配置序列号从 0 递增到 1 以反映此次变更 3. 支持用户或第三方扩展动态自定义快捷面板插件 4. 之前的 readonly 限制阻止了快捷面板插件顺序和配置的修改 Log: 快捷面板插件支持自定义配置 Influence: 1. 验证可以通过 dconfig 或 D-Bus 修改 quickPlugins 配置 2. 测试插件列表的更改在重启后是否持久化 3. 检查快捷面板是否仍按指定顺序显示插件 4. 如需恢复默认值,测试重置功能 5. 确保配置更改不会破坏现有插件功能
18202781743
requested review from
BLumia,
mhduiy,
robertkill,
wjyrich and
yixinshark
August 21, 2026 03:23
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates quick panel plugin configuration to be user-modifiable by changing the quickPlugins dconfig entry from readonly to readwrite and bumping the dock tray configuration serial so the system recognizes the new behavior. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Since
quickPluginsis now readwrite, consider adding or verifying validation on the values (e.g., allowed plugin IDs, ordering, duplicates) to avoid malformed or unsupported configurations being persisted. - Double-check that the new config serial bump to 1 is coordinated with any consumers that may cache or rely on the previous serial, and ensure they correctly reload or migrate existing
quickPluginsvalues when the serial changes.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since `quickPlugins` is now readwrite, consider adding or verifying validation on the values (e.g., allowed plugin IDs, ordering, duplicates) to avoid malformed or unsupported configurations being persisted.
- Double-check that the new config serial bump to 1 is coordinated with any consumers that may cache or rely on the previous serial, and ensure they correctly reload or migrate existing `quickPlugins` values when the serial changes.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
BLumia
approved these changes
Aug 21, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, BLumia The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
third-party extensions
panel plugin order and configuration
Log: 快捷面板插件支持自定义配置
Influence:
order
functionality
chore: 更新快捷面板插件配置权限和序列号
Log: 快捷面板插件支持自定义配置
Influence:
Summary by Sourcery
Enable read-write customization of the quick panel plugin configuration.
New Features:
Enhancements: