Skip to content

chore: update quickPlugins config permissions and serial - #1709

Open
18202781743 wants to merge 1 commit into
linuxdeepin:masterfrom
18202781743:master
Open

chore: update quickPlugins config permissions and serial#1709
18202781743 wants to merge 1 commit into
linuxdeepin:masterfrom
18202781743:master

Conversation

@18202781743

@18202781743 18202781743 commented Aug 21, 2026

Copy link
Copy Markdown
Contributor
  1. Change the quickPlugins permission from readonly to readwrite
  2. Increment the config serial from 0 to 1 to reflect the change
  3. This enables dynamic customization of quick panel plugins by users or
    third-party extensions
  4. The previous readonly restriction prevented modification of the quick
    panel plugin order and configuration

Log: 快捷面板插件支持自定义配置

Influence:

  1. Verify quickPlugins config can be modified via dconfig or D-Bus
  2. Test that changes to the plugin list are persisted after reboot
  3. Check that the quick panel still displays plugins in the specified
    order
  4. Test restoring default values if needed
  5. Ensure the configuration change doesn't break existing plugin
    functionality

chore: 更新快捷面板插件配置权限和序列号

  1. 将 quickPlugins 的权限从 readonly 改为 readwrite
  2. 将配置序列号从 0 递增到 1 以反映此次变更
  3. 支持用户或第三方扩展动态自定义快捷面板插件
  4. 之前的 readonly 限制阻止了快捷面板插件顺序和配置的修改

Log: 快捷面板插件支持自定义配置

Influence:

  1. 验证可以通过 dconfig 或 D-Bus 修改 quickPlugins 配置
  2. 测试插件列表的更改在重启后是否持久化
  3. 检查快捷面板是否仍按指定顺序显示插件
  4. 如需恢复默认值,测试重置功能
  5. 确保配置更改不会破坏现有插件功能

Summary by Sourcery

Enable read-write customization of the quick panel plugin configuration.

New Features:

  • Allow users and third-party extensions to customize the quick panel plugin configuration.

Enhancements:

  • Update the configuration serial to reflect the permission change.

1. Change the quickPlugins permission from readonly to readwrite
2. Increment the config serial from 0 to 1 to reflect the change
3. This enables dynamic customization of quick panel plugins by users or
third-party extensions
4. The previous readonly restriction prevented modification of the quick
panel plugin order and configuration

Log: 快捷面板插件支持自定义配置

Influence:
1. Verify quickPlugins config can be modified via dconfig or D-Bus
2. Test that changes to the plugin list are persisted after reboot
3. Check that the quick panel still displays plugins in the specified
order
4. Test restoring default values if needed
5. Ensure the configuration change doesn't break existing plugin
functionality

chore: 更新快捷面板插件配置权限和序列号

1. 将 quickPlugins 的权限从 readonly 改为 readwrite
2. 将配置序列号从 0 递增到 1 以反映此次变更
3. 支持用户或第三方扩展动态自定义快捷面板插件
4. 之前的 readonly 限制阻止了快捷面板插件顺序和配置的修改

Log: 快捷面板插件支持自定义配置

Influence:
1. 验证可以通过 dconfig 或 D-Bus 修改 quickPlugins 配置
2. 测试插件列表的更改在重启后是否持久化
3. 检查快捷面板是否仍按指定顺序显示插件
4. 如需恢复默认值,测试重置功能
5. 确保配置更改不会破坏现有插件功能
@sourcery-ai

sourcery-ai Bot commented Aug 21, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates quick panel plugin configuration to be user-modifiable by changing the quickPlugins dconfig entry from readonly to readwrite and bumping the dock tray configuration serial so the system recognizes the new behavior.

File-Level Changes

Change Details Files
Allow quick panel plugins configuration to be edited and ensure the change is recognized by configuration consumers.
  • Change the quickPlugins configuration permission from readonly to readwrite so plugin order and settings can be modified via dconfig/D-Bus.
  • Increment the dock tray dconfig schema/config serial value from 0 to 1 to signal a backward-compatible configuration update.
panels/dock/dconfig/org.deepin.ds.dock.tray.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Since quickPlugins is now readwrite, consider adding or verifying validation on the values (e.g., allowed plugin IDs, ordering, duplicates) to avoid malformed or unsupported configurations being persisted.
  • Double-check that the new config serial bump to 1 is coordinated with any consumers that may cache or rely on the previous serial, and ensure they correctly reload or migrate existing quickPlugins values when the serial changes.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Since `quickPlugins` is now readwrite, consider adding or verifying validation on the values (e.g., allowed plugin IDs, ordering, duplicates) to avoid malformed or unsupported configurations being persisted.
- Double-check that the new config serial bump to 1 is coordinated with any consumers that may cache or rely on the previous serial, and ensure they correctly reload or migrate existing `quickPlugins` values when the serial changes.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, BLumia

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants