fix(dock): eliminate several QML runtime/compile warnings - #1706
Draft
mhduiy wants to merge 1 commit into
Draft
Conversation
1. ShellSurfaceItemProxy: set Connections.ignoreUnknownSignals so the cursorShapeRequested handler no longer warns for surfaces lacking the signal. 2. TaskManager: replace the deprecated ListView.onAdd NumberAnimation object-to-signal-handler assignment with a declarative add Transition. 3. TaskManager: break the implicitWidth/implicitHeight binding loop by returning the dock size directly in the spanning layout direction. 4. AppItem/DragItem/ActionLegacyTrayPluginDelegate: pass an explicit target size to grabToImage to avoid the Ignoring sourceSize request warning. 5. OverlapNotify: guard the panelShown lookup so an undefined ListView.view no longer assigns undefined to a bool property. 6. trayitempositionmanager: register the DropIndex gadget as dropIndex lowercase so qmltyperegistrar stops warning about its value-type name. Log: fix multiple QML warnings reported by journalctl/qmltyperegistrar Influence: 1. Verify dock shell surface cursor shape handling still works 2. Verify task manager item add animation still plays 3. Verify dock auto-size layout is unchanged 4. Verify drag image rendering for dock and tray items 5. Verify notification overlap animation initialization fix(dock): 消除任务栏与通知中心若干 QML 运行时/注册告警 1. ShellSurfaceItemProxy:为 Connections 设置 ignoreUnknownSignals, 使 cursorShapeRequested 处理器对缺少该信号的 surface 不再告警。 2. TaskManager:将弃用的 ListView.onAdd NumberAnimation 对象赋值给 信号处理器的写法改为声明式 add Transition。 3. TaskManager:在占满布局方向直接返回 dock 尺寸,打断 implicitWidth/implicitHeight 绑定环。 4. AppItem/DragItem/ActionLegacyTrayPluginDelegate:为 grabToImage 传入 显式目标尺寸,避免 Ignoring sourceSize request 告警。 5. OverlapNotify:对 panelShown 查询加空值守卫,避免未定义的 ListView.view 将 undefined 赋给 bool 属性。 6. trayitempositionmanager:将 DropIndex gadget 注册为 dropIndex 小写,使 qmltyperegistrar 不再告警其值类型名。 Log: 修复 journalctl/qmltyperegistrar 报告的多项 QML 告警 Influence: 1. 验证任务栏 shell surface 光标形状处理仍正常 2. 验证任务管理器条目添加动画仍播放 3. 验证任务栏自适应尺寸布局不变 4. 验证任务栏与托盘条目拖拽图像渲染 5. 验证通知重叠动画初始化 PMS: TASK-394379
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's GuideThis PR fixes several QML runtime/compile warnings in the dock, tray, and notification center by updating signal/connection handling, correct usage of grabToImage, layout sizing logic, animation hooks, QML type registration, and a potentially-null property access. Sequence diagram for updated drag image capture using grabToImagesequenceDiagram
actor User
participant AppItem
participant Drag
participant Qt
User->>AppItem: startDrag()
AppItem->>AppItem: grabToImage(callback, Qt.size(appItem.width, appItem.height))
AppItem-->>AppItem: callback(result)
AppItem->>Drag: set imageSource = result.url
User->>Drag: initiateDrag()
Drag->>Qt: Qt.callLater(function)
Qt-->>Drag: function()
Drag->>Drag: set Drag.active = true
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
mhduiy
marked this pull request as draft
August 20, 2026 09:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Eliminate several QML runtime and compile warnings in dde-shell's dock and notification center by fixing the root cause rather than downgrading log levels. Covers 6 warnings across 7 files; no warning log is downgraded.
Changes
ignoreUnknownSignals: trueso thecursorShapeRequestedhandler no longer warns for surfaces lacking the signal.ListView.onAdd: NumberAnimationobject-to-signal-handler assignment with a declarativeadd: Transition(consistent with the existingremove: Transition).implicitWidth/implicitHeightbinding loop by returning the dock size directly in the spanning layout direction (return value unchanged, dead binding computation dropped).grabToImageto avoid the "Ignoring sourceSize request" warning.panelShownlookup so an undefinedListView.viewno longer assignsundefinedto a bool property.DropIndexgadget asdropIndex(lowercase) so qmltyperegistrar stops warning about its value-type name; C++ struct name and QML property access unchanged.Test
Related