fix: guard hasAuth binding against undefined config (SystemProxyConfigItem.qml:17)

[52cyb]

修复内容 / Fix

修复 dcc-network/qml/SystemProxyConfigItem.qml:17 的运行时警告：

TypeError: Cannot read property 'auth' of undefined

根因 / Root Cause

SystemProxyConfigItem.qml:17 顶层绑定 property bool hasAuth: config.auth 在组件实例化时立即求值。此时 manualProxy 数据经 Qt::QueuedConnection 跨线程异步投递尚未到达主线程，config 仍为 undefined，访问 config.auth 即抛 TypeError。数据到达后绑定重算，功能不受阻断，仅产生运行期警告噪声。

改动 / Change

- property bool hasAuth: config.auth
+ property bool hasAuth: !!(config && config.auth)

仅改动此单行，对 config 为 undefined/null 时返回确定的 false，数据到达后绑定自动重算。不涉及 C++ 或其他 QML 文件。

验证 / Verification

• 代码审核评分 97 分，已通过
• deb 包构建成功（dcc-network-plugin 2.0.99）
• 进入控制中心-网络-系统代理页面，确认不再出现 SystemProxyConfigItem.qml:17 的 TypeError

关联 / Association

• PMS 任务: TASK-392413 https://pms.uniontech.com/task-view-392413.html
• Multica Issue: DDE-150

该 PR 保持 draft（待审核）状态，由人工审核后合并。

Summary by Sourcery

Guard the system proxy authentication binding against undefined configuration data.

Bug Fixes:

• Prevent the system proxy configuration UI from raising a runtime TypeError when authentication configuration is temporarily unavailable.

Chores:

• Update the copyright year in SystemProxyConfigItem.qml.

[deepin-ci-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 52cyb

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR eliminates a runtime TypeError in the SystemProxyConfigItem QML component by making the hasAuth property binding resilient to an undefined config object and updating the SPDX copyright year range header.

Sequence diagram for guarded hasAuth evaluation in SystemProxyConfigItem

sequenceDiagram
    participant SystemProxyConfigItem
    participant QtQueuedConnection
    participant ConfigSource as manualProxy

    SystemProxyConfigItem->>SystemProxyConfigItem: evaluate hasAuth = !!(config && config.auth)
    note over SystemProxyConfigItem: initial config is null

    QtQueuedConnection->>SystemProxyConfigItem: deliver config from manualProxy
    SystemProxyConfigItem->>SystemProxyConfigItem: re-evaluate hasAuth = !!(config && config.auth)
    note over SystemProxyConfigItem: no TypeError when config is undefined/null

Loading

File-Level Changes

Change	Details	Files
Make the hasAuth property robust against undefined or null configuration data to avoid runtime TypeErrors during asynchronous initialization.	Change hasAuth from a direct config.auth binding to a guarded boolean expression that safely handles undefined/null config Ensure that when config is not yet populated, hasAuth deterministically evaluates to false while still updating once data arrives	dcc-network/qml/SystemProxyConfigItem.qml
Adjust the SPDX copyright year range in the SystemProxyConfigItem QML header comment.	Update the copyright year range from 2024 - 2027 to 2024 - 2026 in the SPDX-FileCopyrightText header comment	dcc-network/qml/SystemProxyConfigItem.qml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The hasAuth binding could be simplified to property bool hasAuth: config && config.auth since QML will coerce the expression to bool, avoiding the somewhat opaque double negation.
• Please double-check whether the change to the SPDX-FileCopyrightText year range (from 2024–2027 to 2024–2026) is intentional and consistent with project-wide licensing headers.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The `hasAuth` binding could be simplified to `property bool hasAuth: config && config.auth` since QML will coerce the expression to `bool`, avoiding the somewhat opaque double negation.
- Please double-check whether the change to the SPDX-FileCopyrightText year range (from 2024–2027 to 2024–2026) is intentional and consistent with project-wide licensing headers.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}