server: replace only items with identical attributes - #549
Merged
bilelmoussaoui merged 3 commits intoAug 15, 2026
Merged
Conversation
Contributor
Author
|
Validation update:
The upstream PR workflows are still awaiting first-time-contributor approval. |
Collaborator
|
Both CI failures are unrelated to this one, so ignore them |
julian-corbet
force-pushed
the
fix-exact-create-item-replacement
branch
from
August 14, 2026 11:36
3d81086 to
125cd56
Compare
Contributor
Author
|
Review revision validation: fork CI passes Check, Rustfmt, Clippy, the full Test Suite, and Meson. |
bilelmoussaoui
merged commit Aug 15, 2026
7b8edfb
into
linux-credentials:main
15 of 17 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CreateItem(replace=true)currently reuses the subset matcher needed bySearchItems. As a result, creating an item with a coarser attribute set removes every more-specific item that contains those attributes.This change:
Fixes #541.