Fixes of another failing integration tests - #730
Open
mawilk90 wants to merge 8 commits into
Open
Conversation
Decided mark test as flaky and increase latest_event list to 50 items because when it is run with TPT test user there is a high possibility that other tests may be run in the same time and produce many other events
mawilk90
requested review from
ezilber-akamai,
jriddle-linode and
psnoch-akamai
and removed request for
a team
August 6, 2026 09:04
mawilk90
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the integration/smoke test suite to reduce workflow failures caused by timeouts, transient API errors, and environment variability.
Changes:
- Adjusted integration test timeouts and event-search window to reduce flaky failures.
- Tweaked sharegroup/image-sharing test fixtures to be module-scoped and made image cleanup tolerant of already-deleted images.
- Updated Linode migration test to pick a (supposedly) different target region instead of using a hard-coded region.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/integration/models/sharegroups/test_sharegroups.py | Makes fixtures module-scoped and ignores 404s during image cleanup to reduce teardown flakiness. |
| test/integration/models/networking/test_networking.py | Increases waits for Linode state transitions during VLAN test to reduce timeouts. |
| test/integration/models/linode/test_linode.py | Attempts to migrate to a non-origin region (but currently has an equality/loop issue). |
| test/integration/models/account/test_account.py | Skips a consistently failing login test and adds reruns/increases event scan window for event-based test. |
| test/integration/conftest.py | Extends domain activation wait time in a session fixture to reduce flakiness. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Smoke and integration tests workflows fail again due to multiple reasons (e.g. timeouts). Added some fixes and workarounds.
✔️ How to Test
make test-smokemake test-int