Repository navigation
Add trackRevenue bridge for the native revenue API - #14
Open
ahsanalidotme wants to merge 1 commit into
Open
ahsanalidotme wants to merge 1 commit into
ahsanalidotme wants to merge 1 commit into
Conversation
JS/TS LinkTrail.trackRevenue({ transactionId, value, currency, productId? })
with TS-side validation/normalisation matching the native rules, a typed
LinkTrailRevenueError, TurboModule spec + iOS/Android bridge, README,
CHANGELOG and jest unit tests.
Native compile is blocked on the iOS/Android SDK releases that contain the
revenue API; pins are intentionally not bumped here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes linktrail-io/linktrail-backend#111
Blocked on release (native compile)
The iOS/Android bridge calls
LinkTrail.trackRevenue/trackRevenueAsync, which exist only in unreleased native SDK PRs. The wrapper compiles against the published pins (LinkTrailSDK ~> 0.0.11,io.linktrail:sdk:0.0.5), so native builds will fail until the native SDKs are released and the pins inLinktrailReactNative.podspec/android/build.gradleare bumped (not done here: no version numbers invented). Do not merge/release before then.Deploy order: backend -> native SDK releases -> wrappers (this PR, plus pin bump).
What
LinkTrail.trackRevenue({ transactionId, value, currency, productId? })->Promise<{ id?, attributed, duplicate }>.LinkTrailRevenueError(invalid_transaction_id/invalid_value/invalid_currency) without calling native.npm test. CI workflow untouched (no.github/workflowschanges), so CI does not runnpm testyet.Verified
tscclean,npm run lint0 errors (3 pre-existing warnings), jest 16/16 passing.Unverified
Backend PR (deploy first): https://github.com/linktrail-io/linktrail-backend/pull/138
Dashboard PR: https://github.com/linktrail-io/linktrail-client-dashboard/pull/103
🤖 Generated with Claude Code