Skip to content

Remove External Zero concept #120

Open
#148
Open
Remove External Zero concept#120
#148

Description

@konard
konard
opened on Jul 5, 2022

This branch will no longer exist:

Data/csharp/Platform.Data/Hybrid.cs

Lines 145 to 150 in a670e09

if (_equalityComparer.Equals(value, default) && isExternal)
{
Value = ExternalZero;
}
else
{

No ExternalZero constant anymore:

Data/csharp/Platform.Data/Hybrid.cs

Line 41 in a670e09

public static readonly TLinkAddress ExternalZero = _uInt64ToAddressConverter.Convert(HalfOfNumberValuesRange + 1UL);

Regular (internal) zero becomes external.

Pros:

  • Bitwise operations safety
  • Better performance with conversion of raw numbers
  • Zeros in memory managers are now searchable

Cons:

  • Worse performance of memory managers (additional if branches for zero and indexing of zero values)
  • Huge change across the codebase

Activity

  1. konard commented on Jul 20, 2022

    @konard
    konard
    on Jul 20, 2022
    MemberAuthor

    There is a blocker for this issue, at the moment when we start to index zeros we no longer will have multiple links with source and target set to zero, due to limitation of uniqueness.

  2. konard
    added 2 commits that reference this issue on Sep 11, 2025

    Initial commit with task details for issue #120

    76daa2b

    Remove ExternalZero concept and use regular zero as external

    367246c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions