docs(quotes): document that quote create and execute require TRANSACT - #843
Conversation
Neither endpoint stated which permission it needs. Execute in particular reads as though the Grid-Wallet-Signature header is the whole authorization story on an EMBEDDED_WALLET source, so spell out that the signature and the token permission answer two different questions. Co-Authored-By: dhruvpareek <dhruvpareek@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
✱ Stainless preview builds for gridThis PR will update the cli go kotlin openapi php python ruby typescript
|
Greptile SummaryThe PR clarifies that quote creation and execution require
Confidence Score: 5/5The PR appears safe to merge. The source specifications and both generated bundles remain synchronized, and the added permission and error-response documentation is internally consistent with the shared OpenAPI contracts.
|
| Filename | Overview |
|---|---|
| openapi/paths/quotes/quotes.yaml | Accurately documents the TRANSACT requirement and broadens the existing 403 description while reusing Error403. |
| openapi/paths/quotes/quotes_{quoteId}_execute.yaml | Clarifies the distinct token and wallet-holder authorization requirements and adds a schema-consistent 403 response. |
| openapi.yaml | Generated bundle faithfully mirrors the quote source-file changes. |
| mintlify/openapi.yaml | Mintlify’s generated OpenAPI copy remains identical to the root bundle. |
Reviews (1): Last reviewed commit: "docs(quotes): document that quote create..." | Re-trigger Greptile
Merge activity
|

Summary
Neither
POST /quotesnorPOST /quotes/{quoteId}/executestated which token permission it requires, and neither documented a403for a permission refusal on execute.Execute is the one worth spelling out. Its description covers
Grid-Wallet-Signaturein detail forEMBEDDED_WALLETsources, which reads as though the signature is the whole authorization story. It isn't: the signature proves the wallet holder approved the payment, whileTRANSACTis what authorizes your integration to release it. An integrator building a read-only service could reasonably conclude aVIEWtoken plus a signature was a supported way to execute.Changes
openapi/paths/quotes/quotes_{quoteId}_execute.yaml— state theTRANSACTrequirement and how it relates toGrid-Wallet-Signature; add the403openapi/paths/quotes/quotes.yaml— state theTRANSACTrequirement (a quote is the instrument execute draws on, andimmediatelyExecutemoves funds in the same request); extend the existing403description, which previously named only the End User Terms casemake build:openapi.yaml,mintlify/openapi.yamlVerification
make build— bundles regenerate cleanly; the bundle diff is exactly these four additions, no reformatting of unrelated pathsmake lint— "Woohoo! Your API description is valid.", 0 errors (pre-existing warnings/infos on unrelated beneficiary schemas only)Original PR: #842