Skip to content

Removed AnimationManager from Core, Allow custom animation libraries - #862

Open
jfboeve wants to merge 4 commits into
mainfrom
feat/treeshake-animation-2
Open

Removed AnimationManager from Core, Allow custom animation libraries#862
jfboeve wants to merge 4 commits into
mainfrom
feat/treeshake-animation-2

Conversation

@jfboeve

@jfboeve jfboeve commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

This pull request introduces a major refactor of animation support in the renderer, decoupling the animation manager from the core package and enabling integration with external animation libraries. It adds comprehensive documentation and migration guides, updates the example and test infrastructure to use the new animation approach, and provides a new example project demonstrating custom animation manager integration.

Animation System Refactor

  • Removes AnimationManager and related types from the core package root, requiring explicit import from @lightningjs/renderer/animation and eliminating Node.animate() in favor of user-supplied animation libraries. [1] [2] [3]
  • Updates the renderer to support animation-aware texture processing via a global animation reference counter, allowing both internal and external animation libraries to throttle texture uploads for smoother performance. [1] [2]

Documentation and Migration

  • Adds ANIMATION.md to guide users on integrating third-party animation libraries and animating nodes/shaders, and a migration guide (migration-3x-to-3.3.md) detailing breaking changes and new animation APIs. [1] [2]

Examples and Test Infrastructure

  • Refactors the example test harness to instantiate and wire up the animation manager explicitly, passing an animate function to tests and automation scripts. [1] [2] [3] [4] [5] [6] [7] [8] [9]
  • Updates animation-related tests to use the new animate function instead of the removed Node.animate.

New Example Project

  • Adds a new example project (docs/example-projects/custom-animation-manager/) that demonstrates integrating AnimeJS with the renderer, including configuration files, build scripts, and a particle animation demo. [1] [2] [3] [4] [5]

These changes modernize animation support, improve documentation, and provide clear migration paths and examples for users transitioning to the new system.

@jfboeve
jfboeve requested a review from wouterlucas August 7, 2026 09:13
@jfboeve jfboeve changed the title Feat/treeshake animation 2 Removed AnimationManager from Core, Allow custom animation libraries Aug 7, 2026
@lightning-js lightning-js deleted a comment from CLAassistant Aug 7, 2026
@CLAassistant

CLAassistant commented Aug 7, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@jfboeve
jfboeve force-pushed the feat/treeshake-animation-2 branch from 9996f1e to 0c6d0e8 Compare August 7, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants