Repository navigation
fix: align intersection slowdown and publish reproducible model results - #66
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both simulation modes now spend the configured rolling slowdown once per unique controlled intersection. Standard keeps its additional cautious crossing at red, yellow or unsupported movements; green decisions and failed priority requests preserve the independent common delay. This removes the artificial disadvantage previously applied only to GreenWave.
The reproducible runner fixes three GreenWave-ranked station candidates at density 1.5 and compares both modes at five densities for 200 deterministically sampled incidents. It exports signed actual driving-time savings, failures/on-site cases, all intersection strata, diagnostics, independent fastest stations and revision/dataset provenance. Walking and post-arrival recovery are excluded.
README and bilingual
/docspublish the reviewed 3,000-pair / 6,000-simulation run: 89% faster, 11% tied, no slower cases; mean 71.94 s saved across all station ranks and 37.02 s for rank 1 across densities. The report records methodology, full strata, hashes and limitations. These are model outputs, not measured real-world benefits; repeated station/density combinations are not independent incidents.The old submission history is verified in a local bundle. Main retains an explicit cleanup recipe and archived presentation changes for recreating submission from finalized main, preserving current application source and the current README. No old submission history is merged.
Validation:
No real traffic-controller integration or production deployment is introduced by this change.