Skip to content

feat: preview dispatch routes and independently scroll sidebar panels - #65

Merged
fjarmula merged 3 commits into
mainfrom
codex/route-preview-sidebar-scrolling
Oct 30, 2026
Merged

fjarmula merged 3 commits into
mainfrom
codex/route-preview-sidebar-scrolling

Conversation

@fjarmula

Copy link
Copy Markdown
Member

Summary

  • Selecting an incident now displays the selected emergency unit's planned route before starting a simulation. Dispatch ranking returns geometry from its existing planner, so preview adds no routing request or simulation session. Loading, stale responses, errors, on-site crews and manual unit selection follow the existing dispatch state; preview uses a neutral dashed line and hands over to normal playback.
  • Route Signals and the simulated ITS gateway now share the available desktop sidebar height, with fixed headings and independently scrollable, keyboard-accessible bodies. Controls remain accessible; phone sheets retain their existing gesture behavior.
  • Preserve Polish/English copy, mock/backend geometry parity, markers and existing routing semantics in GreenWave, standard and comparison setup.

Verification

  • Frontend: lint, typecheck, formatting, 1,306 tests and production build passed.
  • Backend: Ruff lint/format, mypy and 1,557 tests passed.
  • Production-build Playwright smoke passed: preview updates in both modes after incident/vehicle changes, no telemetry before Start, clean transition to playback, and independent scrolling with many entries at 1440×900, 1280×720, 1024×600 and 390×844.
  • Existing mobile layout smoke passed, including landscape. Targeted Polish/English preview checks passed. Browser console recorded zero errors and warnings.
  • Pre-commit hooks and diff whitespace checks passed.

Contract or safety impact

Adds optional nullable route_geometry to ranked candidates and regenerates OpenAPI/TypeScript contracts. Uses geometry already calculated by the existing route planner. Simulation start retains authoritative planning and validation; routing algorithms, simulation timing and traffic signal logic are unchanged. Preview starts no simulation session and performs no ITS dispatch or real signal actuation.

Follow-ups

The older full localization smoke has an outdated homepage heading selector and stops before reaching preview. Targeted bilingual preview checks pass; the unrelated homepage selector is unchanged here.

@fjarmula
fjarmula requested a review from piotr-lorek as a code owner October 30, 2026 12:43
@fjarmula
fjarmula merged commit 4b328ac into main Oct 30, 2026
6 checks passed
@fjarmula
fjarmula deleted the codex/route-preview-sidebar-scrolling branch October 30, 2026 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant