Skip to content

fix: clarify ITS feedback and skip unneeded mock recovery - #60

Merged
fjarmula merged 1 commit into
mainfrom
codex/fix-its-feedback
Oct 29, 2026
Merged

fjarmula merged 1 commit into
mainfrom
codex/fix-its-feedback

Conversation

@fjarmula

Copy link
Copy Markdown
Member

Summary

  • Clarify the four simulated ITS response presets: nominal/delayed accept after 1/5 simulated seconds, rejection occurs after 1 second, and missing acknowledgement times out after 8 seconds. Explain that timing starts at each request and acceptance starts signal clearing.
  • Localize the rejection caption and display its 1-second delay in Polish.
  • Fix mock targets entering RECOVERY after passing while priority was still pending. Pending targets now remain NORMAL, including partial passage of a grouped request; accepted targets retain their 15-second recovery.

Verification

  • Frontend lint, typecheck, format check, all 1,266 tests, and production build passed.
  • Backend Ruff lint/format and mypy passed. Full pytest: 1,536 passed; one existing local dataset failure: tests/dataset/test_real_data_smoke.py::test_committed_curated_files_match_the_processed_report. The processed ETL report lacks curated-input hashes; dataset artifacts are unchanged.
  • Backend and mock tests verify all four response timings relative to dispatch at both 1× and 10× playback. Regressions cover full/partial pending passage and preserved 15-second accepted-target recovery.
  • Playwright CLI verified all four presets: nominal/delayed acceptance and rejection/timeout cancellation without completed savings. Polish selector at 390 px displays the translated rejection timing with no horizontal overflow.
  • Independent review found no actionable issues. Updated setup snapshots reflect explanatory copy only; movement/event snapshots are unchanged.

Contract or safety impact

No API, generated-contract, dependency, backend controller behavior, routing-policy, or real signal actuation changes. All ITS responses and signal states remain simulated. Backend timing settings remain configurable; the selector describes the application defaults.

Follow-ups

Regenerate the local processed ETL report to restore curated-input hashes and clear the unrelated dataset check. Rebuild/restart the application after integration to load the corrections.

@fjarmula
fjarmula requested a review from piotr-lorek as a code owner October 29, 2026 17:28
@fjarmula
fjarmula merged commit 2f94348 into main Oct 29, 2026
7 checks passed
@fjarmula
fjarmula deleted the codex/fix-its-feedback branch October 29, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant