Repository navigation
fix: align standard-mode estimates and Green Wave savings - #59
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
tests/dataset/test_real_data_smoke.py::test_committed_curated_files_match_the_processed_report. The existing processed ETL report lacks curated-input hashes forprm_bases.jsonandroundabouts.json; these inputs and the report are outside this change.current_time_saved_sec; movement, elapsed time, signal states, and controller events are preserved.Contract or safety impact
No API shape or generated-contract changes.
current_time_saved_secnow compares Green Wave with the standard ambulance simulation instead of the legacy normal-traffic formula; disabled runs report zero.estimated_normal_time_secremains available for compatibility. All signals and travel times remain simulated; no real signal actuation or routing-policy changes.Follow-ups